Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise #197

Merged
merged 28 commits into from
Mar 3, 2022
Merged

Promise #197

merged 28 commits into from
Mar 3, 2022

Conversation

Beroozam
Copy link
Contributor

No description provided.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash
Copy link
Contributor

Thanks for the translation @Beroozam.
Before I submit a review for other files, I need to know the translation of "Promise".
I think "Promise" doesn't need a translation and it's fine to write it as is.
What do you think @mahdyar?

@mahdyar
Copy link
Member

mahdyar commented Feb 16, 2022

Thanks for the translation @Beroozam. Before I submit a review for other files, I need to know the translation of "Promise". I think "Promise" doesn't need a translation and it's fine to write it as is. What do you think @mahdyar?

I agree. it should be as it was.

@Beroozam
Copy link
Contributor Author

I had no idea about this so I wanted you to help in this translation but what do you think about the sentences that start in Persian that we put the phrase پرامیس and other places from Promise.
@mahdiHash
@mahdyar

@mahdiHash
Copy link
Contributor

I had no idea about this so I wanted you to help in this translation but what do you think about the sentences that start in Persian that we put the phrase پرامیس and other places from Promise. @mahdiHash @mahdyar

If you don't know the meaning of a word/sentence and couldn't find it in the glossary, you can ask us in the Translation Help issue.

Copy link
Contributor

@mahdiHash mahdiHash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions.
You can add the suggestions to a batch and create a commit just once (docs).
For now, ignore the suggestions of translation of "settled" until we see what @mahdyar says.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash
Copy link
Contributor

mahdiHash commented Feb 24, 2022

Hi, @Beroozam.
Are you still working on the changes?
I changed my mind about translation of "settled". I think the meaning you've chosen is fine.
You can add all the suggestions to a batch and submit a commit just once (docs). You only need to separately change the lines which have to be rewritten.

Copy link
Contributor Author

@Beroozam Beroozam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review

// runs when the promise is settled, doesn't matter successfully or not
.finally(() => stop loading indicator)
// so the loading indicator is always stopped before we process the result/error
// زمانی اجرا می‌شود که وعده تسویه شود، مهم نیست موفقیت‌آمیز باشد یا نه
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// زمانی اجرا می‌شود که وعده تسویه شود، مهم نیست موفقیت‌آمیز باشد یا نه
// زمانی اجرا می‌شود که promise تسویه شود، مهم نیست موفقیت‌آمیز باشد یا نه

@mahdiHash
Copy link
Contributor

Hi, @Beroozam.
If the translation is ready, please tell us so we merge it :)

@Beroozam
Copy link
Contributor Author

Beroozam commented Mar 2, 2022

Hi, @mahdiHash
It's done and ready. merge it please .

@mahdiHash
Copy link
Contributor

Thanks for your contribution, @Beroozam.

@mahdyar mahdyar merged commit 115385e into javascript-tutorial:master Mar 3, 2022
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants