Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes: remove deprecated sourcemap generation #19

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

DRSDavidSoft
Copy link
Contributor

@DRSDavidSoft DRSDavidSoft commented Mar 30, 2019

Remove deprecated methods

In previous versions, if gulp-sourcemaps was not used and obfuscator's sourceMap option was set to true, a .map file will be thrown to Gulp stream. (This method is removed in this PR and not recommended for future use.)

This PR is intended to be merged in the next release (2.0.0)

@WuglyakBolgoink
Copy link

WuglyakBolgoink commented Jul 5, 2021

@DRSDavidSoft / @Wain-PC any progress?

@DRSDavidSoft DRSDavidSoft marked this pull request as ready for review July 5, 2021 22:44
@DRSDavidSoft
Copy link
Contributor Author

DRSDavidSoft commented Jul 5, 2021

@WuglyakBolgoink This pull request only removes the previous (old) soucemap generation method that was deprecated with #18. No features is added by this PR since the new method is also present in v1.1.6. (Both are present, and depending on the configuration, one is used.)

This PR is intended to be merged in semver-2.0 as to not break existing code that might use the older sourcemap generation method.

The author can merge this PR and bump the version, now, or later.

@DRSDavidSoft DRSDavidSoft changed the title Breaking changes Breaking changes: remove deprecated sourcemap generation Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants