Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PHP 8.3 support #46

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Added PHP 8.3 support #46

merged 3 commits into from
Jan 24, 2024

Conversation

grossmannmartin
Copy link
Contributor

@grossmannmartin grossmannmartin commented Jan 22, 2024

  • Increased version of infection tool to avoid errors
  • dependencies in a dev build are now installed with --ignore-platform-reqs because dev dependency zalas/phpunit-globals requires PhpUnit 10 in a version that supports PHP 8.3.
  • tests are passing with min deps and high deps (at least locally)
  • increased minimum version of dev dependency zalas/phpunit-doubles, so the minimal deps install passes tests

@jakzal
Copy link
Owner

jakzal commented Jan 23, 2024

Thanks for working on this!

dependencies in a dev build are now installed with --ignore-platform-reqs because dev dependency zalas/phpunit-globals requires PhpUnit 10 in a version that supports PHP 8.3.

I'm afraid this isn't acceptable. We need to think of another solution. Perhaps bringing PHP 8.3 support to the 2.6 version of phpunit-globals would work?

Builds for PHP 8.1 are failing. Support for PHP 8.1 can be dropped if its causing problems.

Verified

This commit was signed with the committer’s verified signature.
grossmannmartin Martin Grossmann

Verified

This commit was signed with the committer’s verified signature.
grossmannmartin Martin Grossmann

Verified

This commit was signed with the committer’s verified signature.
grossmannmartin Martin Grossmann
@grossmannmartin
Copy link
Contributor Author

@jakzal Thank you for your feedback.

That makes sense, I have created the PR in the 2.6 branch zalas/phpunit-globals, so it seems like it should work after

@jakzal jakzal merged commit 7007cc1 into jakzal:2.5 Jan 24, 2024
@jakzal
Copy link
Owner

jakzal commented Jan 24, 2024

Thank you @grossmannmartin 🍺

@grossmannmartin grossmannmartin deleted the php-83 branch January 24, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants