Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent all node to be checked when filtering tree #217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jalalazimi
Copy link

@jalalazimi jalalazimi commented Aug 12, 2020

Hi friends, I updated the following Example to fix #196 issue. If Instead of passing an empty array as a child, we don't pass children, this issue won't occur. I believe we have to prevent happening this bug inside the component, but it's the quickest solution that I've found.

 filtered.push({...node, ...children.length && {children}});

@gaddamsandeeps
Copy link

This fixed all filter problems. Thanks Team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All nodes are checked on filter
2 participants