Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: vaults v2 #215

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ updates:
charmbracelet-deps:
patterns:
- "github.com/charmbracelet/*"
koanf-deps:
patterns:
- "github.com/knadh/koanf/*"
- package-ecosystem: "github-actions"
directory: "/"
schedule:
Expand Down
10 changes: 10 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ require (
github.com/jahvon/glamour v0.8.1-patch3
github.com/jahvon/open-golang v0.0.0-20240522004812-68511c3bc9ef
github.com/jahvon/tuikit v0.0.27
github.com/knadh/koanf/parsers/json v0.1.0
github.com/knadh/koanf/parsers/toml v0.1.0
github.com/knadh/koanf/parsers/yaml v0.1.0
github.com/knadh/koanf/providers/env v1.0.0
github.com/knadh/koanf/providers/file v1.1.2
github.com/knadh/koanf/v2 v2.1.2
github.com/mattn/go-runewidth v0.0.16
github.com/onsi/ginkgo/v2 v2.22.2
github.com/onsi/gomega v1.36.2
Expand Down Expand Up @@ -46,17 +52,20 @@ require (
github.com/dlclark/regexp2 v1.11.5 // indirect
github.com/dustin/go-humanize v1.0.1 // indirect
github.com/erikgeiser/coninput v0.0.0-20211004153227-1c3628e74d0f // indirect
github.com/fsnotify/fsnotify v1.8.0 // indirect
github.com/go-logfmt/logfmt v0.6.0 // indirect
github.com/go-logr/logr v1.4.2 // indirect
github.com/go-task/slim-sprig/v3 v3.0.0 // indirect
github.com/go-toast/toast v0.0.0-20190211030409-01e6764cf0a4 // indirect
github.com/go-viper/mapstructure/v2 v2.2.1 // indirect
github.com/godbus/dbus/v5 v5.1.0 // indirect
github.com/google/go-cmp v0.6.0 // indirect
github.com/google/pprof v0.0.0-20250208200701-d0013a598941 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/gorilla/css v1.0.1 // indirect
github.com/huandu/xstrings v1.5.0 // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/knadh/koanf/maps v0.1.1 // indirect
github.com/lucasb-eyer/go-colorful v1.2.0 // indirect
github.com/mattn/go-isatty v0.0.20 // indirect
github.com/mattn/go-localereader v0.0.1 // indirect
Expand All @@ -70,6 +79,7 @@ require (
github.com/muesli/termenv v0.15.3-0.20240618155329-98d742f6907a // indirect
github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d // indirect
github.com/otiai10/mint v1.6.3 // indirect
github.com/pelletier/go-toml v1.9.5 // indirect
github.com/rivo/uniseg v0.4.7 // indirect
github.com/russross/blackfriday/v2 v2.1.0 // indirect
github.com/sahilm/fuzzy v0.1.1 // indirect
Expand Down
23 changes: 22 additions & 1 deletion go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ github.com/expr-lang/expr v1.16.9 h1:WUAzmR0JNI9JCiF0/ewwHB1gmcGw5wW7nWt8gc6PpCI
github.com/expr-lang/expr v1.16.9/go.mod h1:8/vRC7+7HBzESEqt5kKpYXxrxkr31SaO8r40VO/1IT4=
github.com/frankban/quicktest v1.14.6 h1:7Xjx+VpznH+oBnejlPUj8oUpdxnVs4f8XU8WnHkI4W8=
github.com/frankban/quicktest v1.14.6/go.mod h1:4ptaffx2x8+WTWXmUCuVU6aPUX1/Mz7zb5vbUoiM6w0=
github.com/fsnotify/fsnotify v1.8.0 h1:dAwr6QBTBZIkG8roQaJjGof0pp0EeF+tNV7YBP3F/8M=
github.com/fsnotify/fsnotify v1.8.0/go.mod h1:8jBTzvmWwFyi3Pb8djgCCO5IBqzKJ/Jwo8TRcHyHii0=
github.com/gen2brain/beeep v0.0.0-20240516210008-9c006672e7f4 h1:ygs9POGDQpQGLJPlq4+0LBUmMBNox1N4JSpw+OETcvI=
github.com/gen2brain/beeep v0.0.0-20240516210008-9c006672e7f4/go.mod h1:0W7dI87PvXJ1Sjs0QPvWXKcQmNERY77e8l7GFhZB/s4=
github.com/go-logfmt/logfmt v0.6.0 h1:wGYYu3uicYdqXVgoYbvnkrPVXkuLM1p1ifugDMEdRi4=
Expand All @@ -72,6 +74,8 @@ github.com/go-task/slim-sprig/v3 v3.0.0 h1:sUs3vkvUymDpBKi3qH1YSqBQk9+9D/8M2mN1v
github.com/go-task/slim-sprig/v3 v3.0.0/go.mod h1:W848ghGpv3Qj3dhTPRyJypKRiqCdHZiAzKg9hl15HA8=
github.com/go-toast/toast v0.0.0-20190211030409-01e6764cf0a4 h1:qZNfIGkIANxGv/OqtnntR4DfOY2+BgwR60cAcu/i3SE=
github.com/go-toast/toast v0.0.0-20190211030409-01e6764cf0a4/go.mod h1:kW3HQ4UdaAyrUCSSDR4xUzBKW6O2iA4uHhk7AtyYp10=
github.com/go-viper/mapstructure/v2 v2.2.1 h1:ZAaOCxANMuZx5RCeg0mBdEZk7DZasvvZIxtHqx8aGss=
github.com/go-viper/mapstructure/v2 v2.2.1/go.mod h1:oJDH3BJKyqBA2TXFhDsKDGDTlndYOZ6rGS0BRZIxGhM=
github.com/godbus/dbus/v5 v5.1.0 h1:4KLkAxT3aOY8Li4FRJe/KvhoNFFxo0m6fNuFUO8QJUk=
github.com/godbus/dbus/v5 v5.1.0/go.mod h1:xhWf0FNVPg57R7Z0UbKHbJfkEywrmjJnf7w5xrFpKfA=
github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
Expand All @@ -94,6 +98,20 @@ github.com/jahvon/open-golang v0.0.0-20240522004812-68511c3bc9ef h1:4PS/MNVT6Rsv
github.com/jahvon/open-golang v0.0.0-20240522004812-68511c3bc9ef/go.mod h1:dUmuT5CN6osIeLSRtTPJOf0Yz+qAbcyU6omnCzI+ZfQ=
github.com/jahvon/tuikit v0.0.27 h1:NV+Zzput4twGch+KTwpAOFlR+R/MKtS9DYs3p1sONwg=
github.com/jahvon/tuikit v0.0.27/go.mod h1:zUysbTPUE0tAEB5DfdWvL6AT3g8AZQ+fcwrfUhVXuwA=
github.com/knadh/koanf/maps v0.1.1 h1:G5TjmUh2D7G2YWf5SQQqSiHRJEjaicvU0KpypqB3NIs=
github.com/knadh/koanf/maps v0.1.1/go.mod h1:npD/QZY3V6ghQDdcQzl1W4ICNVTkohC8E73eI2xW4yI=
github.com/knadh/koanf/parsers/json v0.1.0 h1:dzSZl5pf5bBcW0Acnu20Djleto19T0CfHcvZ14NJ6fU=
github.com/knadh/koanf/parsers/json v0.1.0/go.mod h1:ll2/MlXcZ2BfXD6YJcjVFzhG9P0TdJ207aIBKQhV2hY=
github.com/knadh/koanf/parsers/toml v0.1.0 h1:S2hLqS4TgWZYj4/7mI5m1CQQcWurxUz6ODgOub/6LCI=
github.com/knadh/koanf/parsers/toml v0.1.0/go.mod h1:yUprhq6eo3GbyVXFFMdbfZSo928ksS+uo0FFqNMnO18=
github.com/knadh/koanf/parsers/yaml v0.1.0 h1:ZZ8/iGfRLvKSaMEECEBPM1HQslrZADk8fP1XFUxVI5w=
github.com/knadh/koanf/parsers/yaml v0.1.0/go.mod h1:cvbUDC7AL23pImuQP0oRw/hPuccrNBS2bps8asS0CwY=
github.com/knadh/koanf/providers/env v1.0.0 h1:ufePaI9BnWH+ajuxGGiJ8pdTG0uLEUWC7/HDDPGLah0=
github.com/knadh/koanf/providers/env v1.0.0/go.mod h1:mzFyRZueYhb37oPmC1HAv/oGEEuyvJDA98r3XAa8Gak=
github.com/knadh/koanf/providers/file v1.1.2 h1:aCC36YGOgV5lTtAFz2qkgtWdeQsgfxUkxDOe+2nQY3w=
github.com/knadh/koanf/providers/file v1.1.2/go.mod h1:/faSBcv2mxPVjFrXck95qeoyoZ5myJ6uxN8OOVNJJCI=
github.com/knadh/koanf/v2 v2.1.2 h1:I2rtLRqXRy1p01m/utEtpZSSA6dcJbgGVuE27kW2PzQ=
github.com/knadh/koanf/v2 v2.1.2/go.mod h1:Gphfaen0q1Fc1HTgJgSTC4oRX9R2R5ErYMZJy8fLJBo=
github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
Expand Down Expand Up @@ -135,6 +153,8 @@ github.com/otiai10/copy v1.14.1 h1:5/7E6qsUMBaH5AnQ0sSLzzTg1oTECmcCmT6lvF45Na8=
github.com/otiai10/copy v1.14.1/go.mod h1:oQwrEDDOci3IM8dJF0d8+jnbfPDllW6vUjNc3DoZm9I=
github.com/otiai10/mint v1.6.3 h1:87qsV/aw1F5as1eH1zS/yqHY85ANKVMgkDrf9rcxbQs=
github.com/otiai10/mint v1.6.3/go.mod h1:MJm72SBthJjz8qhefc4z1PYEieWmy8Bku7CjcAqyUSM=
github.com/pelletier/go-toml v1.9.5 h1:4yBQzkHv+7BHq2PQUZF3Mx0IYxG7LsP222s7Agd3ve8=
github.com/pelletier/go-toml v1.9.5/go.mod h1:u1nR/EPcESfeI/szUZKdtJ0xRNbUoANCkoOuaOx1Y+c=
github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
Expand Down Expand Up @@ -190,8 +210,9 @@ golang.org/x/tools v0.30.0 h1:BgcpHewrV5AUp2G9MebG4XPFI1E2W41zU1SaqVA9vJY=
golang.org/x/tools v0.30.0/go.mod h1:c347cR/OJfw5TI+GfX7RUPNMdDRRbjvYTS0jPyvsVtY=
google.golang.org/protobuf v1.36.1 h1:yBPeRvTftaleIgM3PZ/WBIZ7XM/eEYAaEyCwvyjq/gk=
google.golang.org/protobuf v1.36.1/go.mod h1:9fA7Ob0pmnwhb644+1+CVWFRbNajQ6iRojtC/QF5bRE=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15 h1:YR8cESwS4TdDjEe65xsg0ogRM/Nc3DYOhEAlW+xobZo=
gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
mvdan.cc/sh/v3 v3.10.0 h1:v9z7N1DLZ7owyLM/SXZQkBSXcwr2IGMm2LY2pmhVXj4=
Expand Down
125 changes: 125 additions & 0 deletions internal/services/vault/config.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,125 @@
package vault

import (
"errors"
"fmt"
"os"
"path/filepath"
"strings"

"github.com/knadh/koanf/parsers/json"
"github.com/knadh/koanf/parsers/toml"
"github.com/knadh/koanf/parsers/yaml"
"github.com/knadh/koanf/providers/env"
"github.com/knadh/koanf/providers/file"
"github.com/knadh/koanf/v2"

"github.com/jahvon/flow/types/config"
)

const (
envPrefix = "FLOW_VAULT_"
vaultConfigFileName = "vaults"
vaultConfigFileExt = ".yaml"
)

type LoadOptions struct {
ConfigPath string
AutoDiscoveryPath string
AllowEnv bool
RequireConfig bool
}

func LoadConfig(opts LoadOptions) (*config.Vault, error) {
k := koanf.New(".")

if opts.AutoDiscoveryPath != "" {
if err := loadFromDir(k, opts.AutoDiscoveryPath); err != nil {
if opts.RequireConfig || !errors.Is(err, os.ErrNotExist) {
return nil, fmt.Errorf("failed to load config dir: %w", err)
}
}
}

if opts.ConfigPath != "" {
if err := loadFromFile(k, opts.ConfigPath); err != nil {
if opts.RequireConfig || !errors.Is(err, os.ErrNotExist) {
return nil, fmt.Errorf("failed to load config file: %w", err)
}
}
}

if opts.AllowEnv {
if err := loadFromEnv(k); err != nil {
return nil, fmt.Errorf("failed to load environment variables: %w", err)
}
}

var cfg config.Vault
if err := k.Unmarshal("", &cfg); err != nil {
return nil, fmt.Errorf("failed to unmarshal config: %w", err)
}

return &cfg, nil
}

func loadFromFile(k *koanf.Koanf, path string) error {
var parser koanf.Parser

switch strings.ToLower(filepath.Ext(path)) {
case ".yaml", ".yml":
parser = yaml.Parser()
case ".json":
parser = json.Parser()
case ".toml":
parser = toml.Parser()
default:
return fmt.Errorf("unsupported config file format: %s", path)
}

if err := k.Load(file.Provider(path), parser); err != nil {
return err
}

return nil
}

// loadFromDir loads configuration from a directory, supporting multiple formats
func loadFromDir(k *koanf.Koanf, path string) error {
if _, err := os.Stat(filepath.Join(path, vaultConfigFileName+vaultConfigFileExt)); err != nil {
if !os.IsNotExist(err) {
return err
}
} else {
return loadFromFile(k, filepath.Join(path, vaultConfigFileName+vaultConfigFileExt))
}
if _, err := os.Stat(filepath.Join(path, vaultConfigFileName+".yml")); err != nil {
if !os.IsNotExist(err) {
return err
}
} else {
return loadFromFile(k, filepath.Join(path, vaultConfigFileName+".yml"))
}
if _, err := os.Stat(filepath.Join(path, vaultConfigFileName+".json")); err != nil {
if !os.IsNotExist(err) {
return err
}
} else {
return loadFromFile(k, filepath.Join(path, vaultConfigFileName+".json"))
}
if _, err := os.Stat(filepath.Join(path, vaultConfigFileName+".toml")); err != nil {
if !os.IsNotExist(err) {
return err
}
} else {
return loadFromFile(k, filepath.Join(path, vaultConfigFileName+".toml"))
}
return fmt.Errorf("no config file found with name %s: %w", vaultConfigFileName, os.ErrNotExist)
}

func loadFromEnv(k *koanf.Koanf) error {
return k.Load(env.Provider(envPrefix, ".", func(s string) string {
return strings.Replace(strings.ToLower(

Check failure on line 122 in internal/services/vault/config.go

View workflow job for this annotation

GitHub Actions / lint

wrapperFunc: use strings.ReplaceAll method in `strings.Replace(strings.ToLower(
strings.TrimPrefix(s, envPrefix)), "_", ".", -1)
}), nil)
}
55 changes: 55 additions & 0 deletions internal/services/vault/mocks/mock_provider.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions internal/services/vault/providers/adapter.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package providers

//go:generate mockgen -destination=mocks/mock_adapter.go -package=mocks github.com/jahvon/flow/internal/services/vault/providers Adapter
type Adapter interface {
Get(key string) (string, error)
Set(key string, value string) error
Delete(key string) error
List() (map[string]string, error)
}
32 changes: 32 additions & 0 deletions internal/services/vault/providers/cli.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
package providers

const CLIProviderName = "cli"

type CLIProvider struct{}

func (p *CLIProvider) New(config map[string]interface{}) (Adapter, error) {
return &CLIAdapter{}, nil
}

type CLIAdapter struct {
getCommand string

Check failure on line 12 in internal/services/vault/providers/cli.go

View workflow job for this annotation

GitHub Actions / lint

field `getCommand` is unused (unused)
setCommand string

Check failure on line 13 in internal/services/vault/providers/cli.go

View workflow job for this annotation

GitHub Actions / lint

field `setCommand` is unused (unused)
deleteCommand string

Check failure on line 14 in internal/services/vault/providers/cli.go

View workflow job for this annotation

GitHub Actions / lint

field `deleteCommand` is unused (unused)
listCommand string

Check failure on line 15 in internal/services/vault/providers/cli.go

View workflow job for this annotation

GitHub Actions / lint

field `listCommand` is unused (unused)
}

func (a *CLIAdapter) Get(key string) (string, error) {
return "", nil
}

func (a *CLIAdapter) Set(key string, value string) error {
return nil
}

func (a *CLIAdapter) Delete(key string) error {
return nil
}

func (a *CLIAdapter) List() (map[string]string, error) {
return nil, nil

Check failure on line 31 in internal/services/vault/providers/cli.go

View workflow job for this annotation

GitHub Actions / lint

return both a `nil` error and an invalid value: use a sentinel error instead (nilnil)
}
27 changes: 27 additions & 0 deletions internal/services/vault/providers/default.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package providers

const DefaultProviderName = "default"

type DefaultProvider struct{}

func (p *DefaultProvider) New(config map[string]interface{}) (Adapter, error) {
return &DefaultAdapter{}, nil
}

type DefaultAdapter struct{}

func (a *DefaultAdapter) Get(key string) (string, error) {
return "", nil
}

func (a *DefaultAdapter) Set(key string, value string) error {
return nil
}

func (a *DefaultAdapter) Delete(key string) error {
return nil
}

func (a *DefaultAdapter) List() (map[string]string, error) {
return nil, nil

Check failure on line 26 in internal/services/vault/providers/default.go

View workflow job for this annotation

GitHub Actions / lint

return both a `nil` error and an invalid value: use a sentinel error instead (nilnil)
}
Loading
Loading