Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure every process tree is using unique shared memory. #30

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ndmitchell
Copy link
Contributor

At the moment if you run fsatrace rwm - -- some command twice in parallel then they end up sharing a buffer and results from both get shared. I have solved this in the patch below by making a unique shared memory buffer for each by adding GetTickCount into the name. I have marked this PR draft because it only works on Windows, so you will want to do something slightly different.

I couldn't find a good source of unique data in a portable way. The high resolution C time functions are not available on MingW, and the 1 second time() is insufficient (both in theory and testing). One option is to make it an #ifdef, or maybe you know of a suitable random source.

@jacereda
Copy link
Owner

I have always considered the "-" output to be a debug-only flag. The caller should provide unique output filenames. Is this for the test suite?

@ndmitchell
Copy link
Contributor Author

It's not required by the test suite, but would be if we ever ran it in parallel. I have no strong practical need for this to be fixed. However the spooky action at a distance aspect of the bug was deeply confusing when I encountered it by accident, and it could recur if two people used log.txt in different directories with a relative path (I think) so tempted to say if the fix is easy enough it might be worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants