Skip to content

Commit

Permalink
Fix changelog and warn message about B3LYP (pyscf#1790)
Browse files Browse the repository at this point in the history
* fix warn message and changelog

* update changelog for b3lyp update [ci skip]

* update b3lyp warning
  • Loading branch information
jeanwsr authored Jul 13, 2023
1 parent 0acc789 commit 4d98498
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ PySCF 2.3.0 (2023-07-04)
- TDDFT gradients for triplet states
- Support complex-valued h1e in fci_slow.absorb_h1e
* Improved
- Update B3LYP functional to make it behave the same to ORCA
- Update B3LYP functional to correspond to the original definition
- Disable CLI parser by default
- Accuracy and performance of RSDF, GDF and RSJK methods
- get_lattice_Ls, and energy cutoff estimation
Expand Down
3 changes: 2 additions & 1 deletion pyscf/dft/libxc.py
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,8 @@ def _xc_key_without_underscore(xc_keys):
# Issue 1480
if not hasattr(__config__, 'B3LYP_WITH_VWN5'):
warnings.warn('Since PySCF-2.3, B3LYP (and B3P86) are changed to the VWN-RPA variant, '
'the same to the B3LYP functional in Gaussian and ORCA (issue 1480). '
'corresponding to the original definition by Stephens et al. (issue 1480) '
'and the same as the B3LYP functional in Gaussian. '
'To restore the VWN5 definition, you can put the setting '
'"B3LYP_WITH_VWN5 = True" in pyscf_conf.py')
elif getattr(__config__, 'B3LYP_WITH_VWN5', False):
Expand Down

0 comments on commit 4d98498

Please sign in to comment.