Carry over audio-only mode in playlist links #4784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syeopite
approved these changes
Jul 9, 2024
syeopite
added
the
need-testing
|
Sorry, misclicked and rerequested the review, didn't mean to do that. |
SamantazFox
reviewed
Jul 21, 2024
krystof1119
force-pushed
the
playlist-link-listen-mode
branch
from
4be4a05
to
5f590dd
Compare
|
Sorry for the late response, time got away from me. I've incorporated the suggestion and rebased the patch onto the current version of the code. |
SamantazFox
approved these changes
Aug 8, 2024
SamantazFox
requested changes
Aug 26, 2024
SamantazFox
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a video is viewed in audio-only mode (/watch?listen=1...), the 'related video' links shown on the video include listen=true in the URL parameters, but if the video was opened as part of the playlist, the links to other videos in that playlist don't include it. This PR changes it such that the links have '&listen=1' appended to them when the user is watching a video in audio-only mode.
I made the same change for mixes, and from a cursory look, it seems to me as though it's working (but I personally don't use mixes, so I can't say for sure).