-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show message when comments are turned off #4051
base: master
Are you sure you want to change the base?
Show message when comments are turned off #4051
Conversation
Tested and checked, works without problems. I haven't tested it on production but it works as is, no need to change settings. However i wasn't able to find the invidious config related to "added a message for when comments are disabled via Invidious config" but it works. Comments on videos WITHOUT comments disabled are displayed. If anyone wants to test this in a debug/test instance it can be easily merged using this commands: $ git fetch origin pull/4051/head:show-comments-turned-off-message
$ git merge show-comments-turned-off-message
$ make I would add translations for |
Oops. I shouldn't have used the word config there. I meant when comments are disabled in Invidious's preferences. See #2585 (comment) for how to do so. Its not very clear in the UI.
Unfortunately Github only lets you suggest changes on lines near changes that occurred within the PR. If you'd like to add translations feel free to make a PR to the |
1183882
to
384707d
Compare
Co-authored-by: Samantaz Fox <[email protected]>
Co-authored-by: Samantaz Fox <[email protected]>
Co-authored-by: Samantaz Fox <[email protected]>
384707d
to
bfbfec2
Compare
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked. |
Fixes: #1092
I want to be awarded the bounty associated to the issue this PR is fixing.
I've also added a message for when comments are disabled via Invidious config.