Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show message when comments are turned off #4051

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

syeopite
Copy link
Member

Fixes: #1092
I want to be awarded the bounty associated to the issue this PR is fixing.

comments

I've also added a message for when comments are disabled via Invidious config.

@syeopite syeopite requested review from SamantazFox and a team as code owners August 14, 2023 07:02
@Fijxu
Copy link
Contributor

Fijxu commented Aug 23, 2023

Tested and checked, works without problems. I haven't tested it on production but it works as is, no need to change settings. However i wasn't able to find the invidious config related to "added a message for when comments are disabled via Invidious config" but it works. Comments on videos WITHOUT comments disabled are displayed.

If anyone wants to test this in a debug/test instance it can be easily merged using this commands:

$ git fetch origin pull/4051/head:show-comments-turned-off-message
$ git merge show-comments-turned-off-message
$ make

image

I would add translations for es.json in this pull request but I don't know how to propose changes to a pull request

@syeopite
Copy link
Member Author

However i wasn't able to find the invidious config related to "added a message for when

Oops. I shouldn't have used the word config there. I meant when comments are disabled in Invidious's preferences.

See #2585 (comment) for how to do so. Its not very clear in the UI.

I would add translations for es.json in this pull request but I don't know how to propose changes to a pull request

Unfortunately Github only lets you suggest changes on lines near changes that occurred within the PR. If you'd like to add translations feel free to make a PR to the show-comments-turned-off-message branch on my fork here https://github.com/syeopite/invidious. It should get automatically included in this PR once merged.

assets/js/watch.js Outdated Show resolved Hide resolved
locales/en-US.json Outdated Show resolved Hide resolved
src/invidious/videos/parser.cr Outdated Show resolved Hide resolved
src/invidious/videos/parser.cr Outdated Show resolved Hide resolved
assets/js/watch.js Outdated Show resolved Hide resolved
@syeopite syeopite force-pushed the show-comments-turned-off-message branch from 384707d to bfbfec2 Compare January 5, 2024 20:22
@github-actions github-actions bot added the stale label Apr 5, 2024
@iv-org iv-org deleted a comment from github-actions bot Apr 25, 2024
@SamantazFox SamantazFox removed the stale label Apr 25, 2024
Copy link

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.

@github-actions github-actions bot added the stale label Jul 25, 2024
@SamantazFox SamantazFox removed the stale label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants