Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman #2626

Closed
Closed

Conversation

706f6f7079646f6f646f6f
Copy link

No description provided.

@unixfox
Copy link
Member

unixfox commented Nov 17, 2021

Closing as there is no need to do that if the docker hub registry is configured as a default registry like on Docker:

@unixfox unixfox closed this Nov 17, 2021
@706f6f7079646f6f646f6f
Copy link
Author

Closing as there is no need to do that if the docker hub registry is configured as a default registry like on Docker:

* https://halukkarakaya.medium.com/how-to-configure-default-search-registries-in-podman-ea930289692

* https://www.redhat.com/sysadmin/manage-container-registries

not default behavior also not desirable

adding does not hurt at all, does not change anything for docker, only makes podman work

adding only makes people happy, not people mad

@SamantazFox
Copy link
Member

SamantazFox commented Nov 17, 2021

Closing as there is no need to do that if the docker hub registry is configured as a default registry like on Docker:

* https://halukkarakaya.medium.com/how-to-configure-default-search-registries-in-podman-ea930289692
* https://www.redhat.com/sysadmin/manage-container-registries

I don't see how this change would hurt. It just makes the repository to get those docker images from explicit.

@SamantazFox SamantazFox reopened this Nov 17, 2021
@unixfox
Copy link
Member

unixfox commented Nov 17, 2021

While I really like podman, our main user base is using Docker and I don't really want to break the workflow of our main user base.

I prefer to document the fix for podman on the documentation website and thus be sure that we don't break anything for our Docker users.

And about the part where I explain in details my motivation:

Here are some example (maybe there are more) where this could break the existing workflow of some of our Docker users:

You may think in both cases the user just have to change the registry URL manually in order to fix the issue, sure but we are still breaking their workflow and that's bad.

And for podman not working by default, I don't fully agree with you because on CentOS 8 (and probably other RedHat based distributions) podman ask you by default which registry you want to use:

[root@podman-inv invidious]# podman build -t invidious -f docker/Dockerfile .
WARN[0000] missing "release" build argument. Try adding "--build-arg release=<VALUE>" to the command line 
[1/2] STEP 1/12: FROM crystallang/crystal:1.2.1-alpine AS builder
? Please select an image: 
    registry.fedoraproject.org/crystallang/crystal:1.2.1-alpine
    registry.access.redhat.com/crystallang/crystal:1.2.1-alpine
    registry.centos.org/crystallang/crystal:1.2.1-alpine
  ▸ docker.io/crystallang/crystal:1.2.1-alpine

Maybe it works differently on Debian or Ubuntu but at least on the Linux distribution by the same creator of podman it works like this.

In conclusion, I'm against merging this change and I prefer to add a specific documentation for podman where we explain how to setup a default registry.

@706f6f7079646f6f646f6f
Copy link
Author

so who to annoy?

all of podman people OR docker people with mirror and docker people with ipv6

probably more people with podman...

@unixfox
Copy link
Member

unixfox commented Nov 17, 2021

It's not about the quantity of people affected, but the fact that we officially supported Docker before podman.

I don't want to break the workflows that are using an officially supported software.

@unixfox
Copy link
Member

unixfox commented Nov 17, 2021

I just created a GitHub issue for adding podman in the documentation: iv-org/documentation#166

@unixfox unixfox closed this Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants