Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite parser for iv-org/documentation#76 #31

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

syeopite
Copy link
Member

@syeopite syeopite commented Jun 19, 2021

This PR rewrites the parser to account for iv-org/documentation#76.

All new fields added by said PR has been added as well.
NEW

This PR also contains the code from #29.

@B0pol
Copy link

B0pol commented Jun 19, 2021

I wouldn’t introduce breaking change for such a small thing. Just add a new field

@syeopite
Copy link
Member Author

Considering this basically rewrites the entire parser I wouldn't exactly consider this PR to be a small change.

@B0pol
Copy link

B0pol commented Jun 19, 2021

I’m talking about the "country" object. Why don’t you add a new field instead of adding a breaking change and moving two fields?

@syeopite syeopite marked this pull request as draft June 19, 2021 15:28
@syeopite
Copy link
Member Author

Fair enough. I've went ahead and unnested it along with the modified object in order to reflect iv-org/documentation#76

@syeopite syeopite marked this pull request as ready for review June 27, 2021 19:41
@syeopite syeopite marked this pull request as draft August 12, 2021 08:09
@syeopite syeopite marked this pull request as ready for review August 15, 2021 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Work In Progress
Development

Successfully merging this pull request may close these issues.

2 participants