Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup readReply() logic #181

Merged
merged 4 commits into from
Dec 16, 2024
Merged

refactor: cleanup readReply() logic #181

merged 4 commits into from
Dec 16, 2024

Conversation

iuioiua
Copy link
Owner

@iuioiua iuioiua commented Dec 16, 2024

  • Reduces amount of functions that are not used in multiple places.
  • Reduces the amount of additional redundant promise creation.
  • Moves the functionality of AsyncQueue into RedisClient.
  • Removes a little extra redundant work in various spots.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (a415cb7) to head (1368a3d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   99.06%   98.75%   -0.32%     
==========================================
  Files           1        1              
  Lines         213      160      -53     
  Branches       31       30       -1     
==========================================
- Hits          211      158      -53     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua merged commit 26494d7 into main Dec 16, 2024
3 checks passed
@iuioiua iuioiua deleted the refactor branch December 16, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant