[WIP] Support HTTP authentication prompt after 401 #5331
Conversation
simonlsk
force-pushed
the
http-intuitive-auth
branch
from
2ddec61 to
53404df
Compare
dvc/tree/http.py
Outdated
| user = ask_username(host) | ||
| self.path_info.user = user | ||
| config_level = "local" | ||
| with self.repo.config.edit(config_level) as conf: |
There was a problem hiding this comment.
There have been a few questions about this before, but our remotes don't modify their own config. Some remotes like gdrive, save things to .dvc/tmp, but don't modify the config. Looks like we don't really need to do it, right? We can ask again or make the user set user in .dvc/config.local by himself. Or am I missing something?
There was a problem hiding this comment.
I see how it breaks the design a little bit.
Asking again / asking the user to run a command is a bit unnatural UX (different than git for instance). Can you try to help me find a more appropriate way to save the username as a side effect, that will be satisfying design-wise?
There was a problem hiding this comment.
@simonlsk Great point. Where does git store the username in such cases?
There was a problem hiding this comment.
That's a good question, my git installation set my credential.helper as osxkeychain and I am only prompted once about any combination of user, host, password. I thought that you could only fetch a password once you know the user, host combination and that the username was being saved in .git/config, but I was wrong. I just read the code in git and it looks like it can fetch entries without knowing the username.
I will try to workaround this, and let you know.
|
Oops, we had an issue with a recent pytest version. Fixed in upstream, please rebase. |
simonlsk
force-pushed
the
http-intuitive-auth
branch
from
53404df to
2c4c033
Compare
|
There is a security issue using keyring for that purpose. Closing the PR for now. |
Addresses issue iterative/dvc-http#26.
Affected components:
HTTP tree
When HTTP request returns 401 with
www-authenticate, the username is prompted if not existent, then the password is prompted if inexistent or fetched from OS secret manager.If
ask_passwordis set totrueprompt for password anyway.