Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odb: add exists_prefix method #88

Merged
merged 2 commits into from
Jul 3, 2022
Merged

odb: add exists_prefix method #88

merged 2 commits into from
Jul 3, 2022

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Jul 3, 2022

Requires for testtool in dvc-data for supporting short_oid as an argument. I forgot to add in dvc-objects, thought I did.
It's not very optimal, but since we only require for one call in testtool, that should be fine.
iterative/dvc-data@3e0362a

@skshetry skshetry requested a review from efiop July 3, 2022 02:49
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2022

Codecov Report

Merging #88 (b733da2) into main (1a03409) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   65.50%   65.78%   +0.28%     
==========================================
  Files          39       39              
  Lines        2406     2426      +20     
  Branches      374      379       +5     
==========================================
+ Hits         1576     1596      +20     
  Misses        801      801              
  Partials       29       29              
Impacted Files Coverage Δ
src/dvc_objects/db.py 100.00% <100.00%> (ø)
tests/test_odb.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a03409...b733da2. Read the comment docs.

@efiop efiop merged commit 9d52e26 into main Jul 3, 2022
@skshetry skshetry deleted the exists_prefix branch July 3, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants