Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the import to DataChain and C to functional #995

Merged
merged 4 commits into from
Mar 26, 2025

Conversation

amritghimire
Copy link
Contributor

@amritghimire amritghimire commented Mar 25, 2025

  • Fix imports for tests
  • Fix imports in examples and other files

Sorry for making you review this changes for 66 files./

@amritghimire amritghimire self-assigned this Mar 25, 2025
Copy link

cloudflare-workers-and-pages bot commented Mar 25, 2025

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: db6cd08
Status: ✅  Deploy successful!
Preview URL: https://b1520f71.datachain-documentation.pages.dev
Branch Preview URL: https://amrit-functional-change.datachain-documentation.pages.dev

View logs

@amritghimire amritghimire requested review from ilongin, dreadatour and a team March 25, 2025 15:08
Copy link
Contributor

@dreadatour dreadatour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.09%. Comparing base (212edb1) to head (db6cd08).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/datachain/cli/commands/show.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   88.34%   88.09%   -0.26%     
==========================================
  Files         145      145              
  Lines       12280    12279       -1     
  Branches     1699     1699              
==========================================
- Hits        10849    10817      -32     
- Misses       1014     1045      +31     
  Partials      417      417              
Flag Coverage Δ
datachain 88.02% <90.47%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amritghimire amritghimire merged commit 93c0121 into main Mar 26, 2025
34 of 35 checks passed
@amritghimire amritghimire deleted the amrit/functional-change branch March 26, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants