Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs update #921

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Docs update #921

merged 1 commit into from
Feb 14, 2025

Conversation

dreadatour
Copy link
Contributor

@dreadatour dreadatour commented Feb 12, 2025

Refactor data models docs pages + add docs for BBox, Pose and Segment models.

@dreadatour dreadatour requested a review from a team February 12, 2025 13:10
@dreadatour dreadatour self-assigned this Feb 12, 2025
Copy link

cloudflare-workers-and-pages bot commented Feb 12, 2025

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 88d9559
Status: ✅  Deploy successful!
Preview URL: https://4acbd2a2.datachain-documentation.pages.dev
Branch Preview URL: https://docs-update.datachain-documentation.pages.dev

View logs

@dreadatour dreadatour mentioned this pull request Feb 12, 2025
1 task
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.66%. Comparing base (de171c6) to head (88d9559).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #921   +/-   ##
=======================================
  Coverage   87.66%   87.66%           
=======================================
  Files         130      130           
  Lines       11698    11698           
  Branches     1592     1592           
=======================================
  Hits        10255    10255           
  Misses       1043     1043           
  Partials      400      400           
Flag Coverage Δ
datachain 87.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dreadatour dreadatour changed the base branch from main to models-update February 12, 2025 13:48
noxfile.py Outdated Show resolved Hide resolved
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot. a Few comments, PTAL.

Copy link
Contributor

@ilongin ilongin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dreadatour dreadatour changed the base branch from models-update to main February 14, 2025 01:56
@dreadatour
Copy link
Contributor Author

I've decided to change the base of this PR to main to do not block merging. It is not rely on #919 now.

@dreadatour dreadatour merged commit c889406 into main Feb 14, 2025
37 checks passed
@dreadatour dreadatour deleted the docs-update branch February 14, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants