Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assume monkeypatch.chdir does not work in multiprocess spawn #903

Closed
wants to merge 1 commit into from

Conversation

mattseddon
Copy link
Member

No description provided.

Copy link

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: a55bf5a
Status: ✅  Deploy successful!
Preview URL: https://a6ff053b.datachain-documentation.pages.dev
Branch Preview URL: https://patch-spawn-path.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (86fc806) to head (a55bf5a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #903   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files         130      130           
  Lines       11639    11641    +2     
  Branches     1579     1579           
=======================================
+ Hits        10215    10217    +2     
  Misses       1029     1029           
  Partials      395      395           
Flag Coverage Δ
datachain 87.69% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattseddon mattseddon closed this Feb 7, 2025
@skshetry
Copy link
Member

skshetry commented Feb 7, 2025

That test only started failing since yesterday, so maybe some dependency got updated?

@skshetry
Copy link
Member

skshetry commented Feb 7, 2025

It's also interesting that the test only fails on Python 3.12.

@skshetry
Copy link
Member

skshetry commented Feb 7, 2025

I am able to reproduce this with:

nox -s tests-3.12 -- tests/func/test_query.py::test_shutdown_on_sigterm

@skshetry
Copy link
Member

skshetry commented Feb 7, 2025

datamodel-code-generator had a new release (0.27.0) that is now bringing more dependencies, including anyio (which comes from httpx). anyio is what is causing issues, but idk what.
I'll try looking into this on Monday.

We can pin to datamodel-code-generator<0.27 temporarily.

koxudaxi/datamodel-code-generator#2288 (comment)

@shcheklein
Copy link
Member

@skshetry

We can pin to datamodel-code-generator<0.27 temporarily.

sounds good, thanks

@skshetry
Copy link
Member

skshetry commented Feb 8, 2025

That has been fixed upstream, so we don't need to pin it. But I do need to look why it hangs with anyio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants