Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loadgroup to test_shutdown_on_sigterm #902

Closed
wants to merge 1 commit into from
Closed

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Feb 6, 2025

I've seen test_shutdown_on_sigterm fail a few times in the CI:

My assumption is that the following line is causing issues when the tests are distributed between workers (we use tmp_dir fixture).

pathlib.Path("ready").touch(exist_ok=False)

I've added them to the same xdist loadgroup so they won't be able to run into one another.

Copy link

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: f2c999e
Status: ✅  Deploy successful!
Preview URL: https://55589e49.datachain-documentation.pages.dev
Branch Preview URL: https://add-load-group.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.74%. Comparing base (86fc806) to head (f2c999e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
- Coverage   87.76%   87.74%   -0.02%     
==========================================
  Files         130      130              
  Lines       11639    11639              
  Branches     1579     1579              
==========================================
- Hits        10215    10213       -2     
- Misses       1029     1031       +2     
  Partials      395      395              
Flag Coverage Δ
datachain 87.67% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattseddon mattseddon closed this Feb 6, 2025
@mattseddon mattseddon deleted the add-load-group branch February 6, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant