-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added columns as case values #872
Conversation
Deploying datachain-documentation with
|
Latest commit: |
fbf1ee1
|
Status: | ✅ Deploy successful! |
Preview URL: | https://f84dd2f5.datachain-documentation.pages.dev |
Branch Preview URL: | https://ilongin-871-columns-as-case.datachain-documentation.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
==========================================
- Coverage 87.65% 87.65% -0.01%
==========================================
Files 128 128
Lines 11457 11461 +4
Branches 1544 1546 +2
==========================================
+ Hits 10043 10046 +3
- Misses 1026 1027 +1
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Up until now we only allowed python primitives as case values like str, int, float ...
With this PR we will allow columns as well (note that this also adds ability for columns as outcomes in
ifelse
as it usescase
under the hood ), e.g