-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] シュミレーターのRideStatus表示のうち"完了"を"空車"として表示する / 他 #612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@narirou @imamiya-masaki レビューお願いいたします。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rideStatus === "COMPLETED"を、FE上ではundefinedで扱うようにしていただきたいです 🙏
popunbom
force-pushed
the
frontend/refactor/completed-as-matching
branch
from
December 4, 2024 13:01
591a255
to
068650d
Compare
popunbom
force-pushed
the
frontend/refactor/completed-as-matching
branch
from
December 4, 2024 13:04
068650d
to
7c53ea8
Compare
popunbom
changed the title
[FE] シュミレーターのRideStatus表示のうち"完了"を"空車"として表示する
[FE] シュミレーターのRideStatus表示のうち"完了"を"空車"として表示する / 他
Dec 4, 2024
narirou
approved these changes
Dec 5, 2024
frontend/app/components/modules/simulator-chair-status/simulator-chair-status.tsx
Outdated
Show resolved
Hide resolved
…or-chair-status.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates: #241
下記に対応しました
評価前 → 評価後