-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfile to include cspell as the spell checker for istio.io #3161
Conversation
Hi @Ajay-singh1. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@craigbox @howardjohn @dhawton I need your approval here. |
Because of the way the scripts work, you're going to end up with a container that has |
/retest |
@craigbox We can cleanly merge this PR now. |
I encourage you to make the changes for the linter in this PR also, as it takes a while for these to filter through to the other environments. |
@craigbox I have included the changes for the linter.I did forgot to add a v so the tool is not getting pulled by the container and the checks were failing now it will work fine. |
Ah, right, I see that came through now in #3155. |
Related issue:- Issue