Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to include cspell as the spell checker for istio.io #3161

Merged
merged 4 commits into from
Mar 25, 2025

Conversation

Ajay-singh1
Copy link
Contributor

Related issue:- Issue

@Ajay-singh1 Ajay-singh1 requested a review from a team as a code owner March 20, 2025 13:09
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Mar 20, 2025
@istio-testing
Copy link
Contributor

Hi @Ajay-singh1. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Ajay-singh1
Copy link
Contributor Author

@howardjohn @dhawton

@howardjohn
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Mar 20, 2025
@Ajay-singh1
Copy link
Contributor Author

@craigbox @howardjohn @dhawton I need your approval here.

@craigbox
Copy link
Contributor

Because of the way the scripts work, you're going to end up with a container that has cspell and a script that calls mdspell. Until the change is merged in istio/istio.io, I would recommend we install both.

@Ajay-singh1
Copy link
Contributor Author

/retest

@Ajay-singh1
Copy link
Contributor Author

@craigbox We can cleanly merge this PR now.

@Ajay-singh1 Ajay-singh1 changed the title Update Dockerfile to remove mdspell and replace it with cspell as the spell checker for istio.io Update Dockerfile to include cspell as the spell checker for istio.io Mar 24, 2025
@craigbox
Copy link
Contributor

I encourage you to make the changes for the linter in this PR also, as it takes a while for these to filter through to the other environments.

@Ajay-singh1
Copy link
Contributor Author

@craigbox I have included the changes for the linter.I did forgot to add a v so the tool is not getting pulled by the container and the checks were failing now it will work fine.

@craigbox
Copy link
Contributor

Ah, right, I see that came through now in #3155.

@istio-testing istio-testing merged commit 4118cfc into istio:master Mar 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants