bump golang version to 1.23.7

[aryan16]

Upgrade golang version for Istio 1.23

[istio-policy-bot]

😊 Welcome @aryan16! This is either your first contribution to the Istio tools repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

[mikemorris]

#63 ERROR: process "/bin/sh -c curl --proto '=https' -v --tlsv1.2 -sSf https://sh.rustup.rs/ | sh -s -- -y -v --default-toolchain ${RUST_VERSION} --profile minimal --component rustfmt clippy && /home/.cargo/bin/rustup default ${RUST_VERSION} && mv /home/.cargo/bin/* /usr/bin" did not complete successfully: exit code: 1

Is this just a transitory issue downloading rustup?

/retest

[istio-testing]

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
containers-test_tools_release-1.23	113ed7d	link	true	/test containers-test
containers-test-arm64_tools_release-1.23	113ed7d	link	true	/test containers-test-arm64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mikemorris]

Okay, not transitory, errors appear to be:

error: error: unexpected argument 'clippy' found

Maybe need to add an explicit --component before clippy at https://github.com/istio/tools/blob/master/docker/build-tools/Dockerfile#L649 if this changed in a newer rustup version (and backport to all maintained branches) because it looks like we're pulling the latest rustup instead of using a pinned version.

UPDATE: Yep, looks like this CLI parsing changed in rustup 1.28.0 published on March 4th, in rust-lang/rustup#4179

 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 32)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 284)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 389)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 411)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 474)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 516)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 553)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 658)
Dockerfile:630 

Looks like @Stevenjin8 may have hit this previously in #3091 and we could possibly backport that PR in it's entirety, or just apply those same casing changes.

[aryan16]

Okay, not transitory, errors appear to be:

error: error: unexpected argument 'clippy' found

Maybe need to add an explicit --component before clippy at https://github.com/istio/tools/blob/master/docker/build-tools/Dockerfile#L649 if this changed in a newer rustup version (and backport to all maintained branches) because it looks like we're pulling the latest rustup instead of using a pinned version.

UPDATE: Yep, looks like this CLI parsing changed in rustup 1.28.0 published on March 4th, in rust-lang/rustup#4179

 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 32)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 284)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 389)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 411)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 474)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 516)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 553)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 658)
Dockerfile:630 

Looks like @Stevenjin8 may have hit this previously in #3091 and we could possibly backport that PR in it's entirety, or just apply those same casing changes.

Cool, made these changes. I see problem with my git branches, so created a new PR - #3163