Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve documentation for tag and rev label #3418

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+28 −20
Open

improve documentation for tag and rev label #3418

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b694147
improve documentation for tag and rev label
therealmitchconnors Jan 17, 2025
efce25b
make gen
therealmitchconnors Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions label/labels.gen.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions label/labels.pb.html
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions label/labels.yaml
View file
Original file line number Diff line number Diff line change
@@ -61,20 +61,22 @@ labels:
- WorkloadEntry

- name: istio.io/rev
featureStatus: Alpha
description: Istio control plane revision associated with the resource; e.g. `canary`
featureStatus: Beta
description: Istio control plane revision or tag associated with the resource; e.g. `canary`
hidden: false
deprecated: false
resources:
- Namespace
- Gateway
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we may want to start disambiguating between k8s GW and Istio GW

- Pod

- name: istio.io/tag
featureStatus: Alpha
description: Istio control plane tag name associated with the resource; e.g. `canary`
description: Istio control plane tag name associated with the resource - for internal use only
hidden: false
deprecated: false
resources:
- Namespace
- MutatingWebhookConfiguration

- name: operator.istio.io/component
featureStatus: Alpha