fix: handle end out of range errors

[hurstindustries]

Fixes issue Cannot read properties of undefined (reading 'endCol') in lib/range.js

See comment by @devcorraliza on #198 (comment) for context

[SimenB]

Please include a test 🙂

[devcorraliza]

Hi, any pending task to review/merge?

[wolandec]

Hi, could you please release this change?

[SimenB]

@jridgewell does this seem reasonable to you?

[jridgewell]

I think this fix is in the wrong location, because it's so far from the actual spot the bug is introduced. I would update

v8-to-istanbul/lib/source.js

Lines 105 to 110 in b5ecd82

	end = originalPositionFor(sourceMap, {
	line: lines[lines.length - 1].line,
	column: endCol - lines[lines.length - 1].startCol,
	bias: LEAST_UPPER_BOUND
	})
	end.column -= 1

      const maybeEnd = originalPositionFor(sourceMap, {
        line: lines[lines.length - 1].line,
        column: endCol - lines[lines.length - 1].startCol,
        bias: LEAST_UPPER_BOUND
      })
      if (maybeEnd) {
        end = maybeEnd
        end.column -= 1
      }

[jridgewell]

Actually, this seems to be fixing an unrelated issue? The case I debugged in #198 does not hit this error case. I'm not sure how this case is hit.

[wolandec]

The changes in this PR fix that reading 'endCol' error in our project.

This works for us too lines[mid]?.endCol . Hope it helps.

v8-to-istanbul/lib/range.js

Line 22 in b5ecd82

while (mid >= 0 && startCol < lines[mid].endCol && endCol >= lines[mid].startCol) {

      while (mid >= 0 && startCol < lines[mid]?.endCol && endCol >= lines[mid].startCol) {

[bcoe]

Not sure what the best solution is here between the options presented by @jridgewell, @wolandec, and @hurstindustries -- open to suggestions from someone who's dug into this deeply.