fix: Make sure glob and minimatch are case insenitive on win32

.gitignore

@@ -2,3 +2,4 @@
 node_modules/*
 coverage
 .nyc_output
+.idea

extension-matcher-posix.js

@@ -0,0 +1,5 @@
+'use-strict'
+
+module.exports = (filename) => {
+    return ext => filename.endsWith(ext);
+};

extension-matcher-win32.js

@@ -0,0 +1,5 @@
+'use strict'
+
+module.exports = (filename) => {
+    return ext => filename.toLowerCase().endsWith(ext.toLowerCase());
+};

extension-matcher.js

@@ -0,0 +1,8 @@
+'use strict';
+
+if (process.platform === 'win32') {
+    module.exports = require("./extension-matcher-win32");
+} else {
+    module.exports = require("./extension-matcher-posix");
+}
+

index.js

@@ -5,7 +5,9 @@ const { promisify } = require('util');
 const glob = promisify(require('glob'));
 const minimatch = require('minimatch');
 const { defaults } = require('@istanbuljs/schema');
-const isOutsideDir = require('./is-outside-dir');
+const { isOutsideDir, minimatchOptions } = require('./is-outside-dir');
+const extensionMatcher = require("./extension-matcher");
+
 
 class TestExclude {
     constructor(opts = {}) {
@@ -77,7 +79,7 @@ class TestExclude {
     shouldInstrument(filename, relFile) {
         if (
             this.extension &&
-            !this.extension.some(ext => filename.endsWith(ext))
+            !this.extension.some(extensionMatcher(filename))
         ) {
             return false;
         }
@@ -95,8 +97,7 @@ class TestExclude {
             pathToCheck = relFile.replace(/^\.[\\/]/, ''); // remove leading './' or '.\'.
         }
 
-        const dot = { dot: true };
-        const matches = pattern => minimatch(pathToCheck, pattern, dot);
+        const matches = pattern => minimatch(pathToCheck, pattern, minimatchOptions);
         return (
             (!this.include || this.include.some(matches)) &&
             (!this.exclude.some(matches) || this.excludeNegated.some(matches))
@@ -105,7 +106,7 @@ class TestExclude {
 
     globSync(cwd = this.cwd) {
         const globPatterns = getExtensionPattern(this.extension || []);
-        const globOptions = { cwd, nodir: true, dot: true };
+        const globOptions = Object.assign({ cwd, nodir: true }, minimatchOptions);
         /* If we don't have any excludeNegated then we can optimize glob by telling
          * it to not iterate into unwanted directory trees (like node_modules). */
         if (this.excludeNegated.length === 0) {
@@ -119,7 +120,7 @@ class TestExclude {
 
     async glob(cwd = this.cwd) {
         const globPatterns = getExtensionPattern(this.extension || []);
-        const globOptions = { cwd, nodir: true, dot: true };
+        const globOptions = Object.assign({ cwd, nodir: true }, minimatchOptions);
         /* If we don't have any excludeNegated then we can optimize glob by telling
          * it to not iterate into unwanted directory trees (like node_modules). */
         if (this.excludeNegated.length === 0) {

is-outside-dir-posix.js

@@ -2,6 +2,11 @@
 
 const path = require('path');
 
-module.exports = function(dir, filename) {
-    return /^\.\./.test(path.relative(dir, filename));
+module.exports = {
+    isOutsideDir(dir, filename) {
+        return /^\.\./.test(path.relative(dir, filename));
+    },
+    minimatchOptions: {
+        dot: true
+    }
 };

is-outside-dir-win32.js

@@ -2,9 +2,14 @@
 
 const path = require('path');
 const minimatch = require('minimatch');
-
-const dot = { dot: true };
-
-module.exports = function(dir, filename) {
-    return !minimatch(path.resolve(dir, filename), path.join(dir, '**'), dot);
+const minimatchOptions = {
+    dot: true,
+    nocase: true // win32 should be case insensitive matches
 };
+
+module.exports = {
+    isOutsideDir(dir, filename) {
+        return !minimatch(path.resolve(dir, filename), path.join(dir, '**'), minimatchOptions)
+    },
+    minimatchOptions
+}

nyc.config.js

@@ -14,6 +14,8 @@ module.exports = {
     exclude: [
         ...defaultExclude,
         'is-outside-dir.js',
-        isWindows ? 'is-outside-dir-posix.js' : 'is-outside-dir-win32.js'
+        'extension-matcher.js',
+        isWindows ? 'is-outside-dir-posix.js' : 'is-outside-dir-win32.js',
+        isWindows ? 'extension-matcher-posix.js' : 'extension-matcher-win32.js'
     ]
 };

tap-snapshots/test-glob.js-TAP.test.js

@@ -40,6 +40,13 @@ Array [
 ]
 `
 
+exports[`test/glob.js TAP handles case insensitive matches on windows > must match snapshot 1`] = `
+Array [
+  "file1.js",
+  "file2.js",
+]
+`
+
 exports[`test/glob.js TAP should exclude the node_modules folder by default > absolute constructor cwd 1`] = `
 Array [
   "file1.js",

test/glob.js

@@ -95,3 +95,15 @@ t.test('allows negated include patterns', t =>
         }
     })
 );
+
+if (process.platform === 'win32') {
+    t.test('handles case insensitive matches on windows', t =>
+        testHelper(t, {
+            options: {
+                cwd,
+                extension: extension.toUpperCase(),
+                include: ['file1.js', 'FILE2.js']
+            }
+        })
+    );
+}

test/test-exclude.js

@@ -67,6 +67,26 @@ if (process.platform === 'win32') {
             no: ['D:\\project\\foo.js']
         })
     );
+
+    t.test('should handle case insensitive drives on win32', t =>
+        testHelper(t, {
+            options: {
+                cwd: 'C:\\project'
+            },
+            yes: ['c:\\project\\foo.js']
+        })
+    );
+
+    t.test('should handle case insensitive paths when on win32', t =>
+        testHelper(t, {
+            options: {
+                exclude: ['foo.js'],
+                include: ['boo.js']
+            },
+            no: ['FOO.js'],
+            yes: ['BOO.js']
+        })
+    );
 }
 
 t.test('can instrument files outside cwd if relativePath=false', t =>