Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support enums and class constants (possibly breaking) #173

Merged
merged 6 commits into from
Mar 9, 2025

Conversation

gordonwatts
Copy link
Member

@gordonwatts gordonwatts commented Mar 9, 2025

  • Add support for enum's by evaluating them inline (e.g. like a captured constant or variable)
  • Support similar for class constants.

Minor

  • Improve the running of CI so only on PR's or direct pushes to master.

Breaking

The way objects are returning in [cpp_vfloat] is now by an actual reference rather than an ast.Name. This makes more sense going forward - type resolution, etc., is done correctly now. However, downstream things,, like the xAOD calib stuff for parameterized calls, might need to be updated to support this.

@gordonwatts gordonwatts self-assigned this Mar 9, 2025
@gordonwatts gordonwatts added the enhancement New feature or request label Mar 9, 2025
@gordonwatts gordonwatts merged commit 6672b98 into master Mar 9, 2025
16 checks passed
@gordonwatts gordonwatts deleted the feat/enum_update branch March 9, 2025 17:19
This was referenced Mar 9, 2025
@gordonwatts gordonwatts changed the title Support enums and class constants Support enums and class constants (possibly breaking) Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant