Sglang integrarion: Fix dtype mismatch #456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yichiche
commented
Feb 5, 2025
yichiche
commented
- Cast all int64 values to int32 to fix compatibility issue of sglang interface.
- Add support for tkl.bf16 to expand data type handling.
harsh-nod
reviewed
Feb 5, 2025
| @@ -162,12 +163,12 @@ def extend_attention( | |||
| N_KV, H_KV, D_KV, ADDRESS_SPACE, wave_input_dtype, v_cache_layout | |||
| ], | |||
| block_table: tkl.Memory[ | |||
| S, N_KV, GLOBAL_ADDRESS_SPACE, wave_size_dtype, block_table_layout | |||
| S, N_KV, GLOBAL_ADDRESS_SPACE, tkl.i32, block_table_layout | |||
| ], | |||
| request_indices: tkl.Memory[S, GLOBAL_ADDRESS_SPACE, wave_size_dtype], | |||
There was a problem hiding this comment.
since this is a very specific signature, I think you can remove wave_size_dtype and set it to tkl.i64. This will also require some changes to the tests. Would you like to fix this or do you want me to take it over?
harsh-nod
reviewed
Feb 5, 2025
| @@ -202,11 +204,15 @@ def first_loop( | |||
| elements_per_thread=LOAD_ELEMS_PER_THREAD_QK, | |||
| mapping=q_mapping, | |||
| ) | |||
| if wave_input_dtype == tkl.bf16: | |||
| q_reg = tkw.cast(tkw.cast(q_reg, tkl.f32), tkl.f16) | |||
There was a problem hiding this comment.
I realize now that this is not necessary, so we can remove this here and elsewhere.
raikonenfnu
reviewed
Feb 5, 2025
| @@ -215,12 +221,14 @@ def first_loop( | |||
| e_delta = tkw.exp2(x_j - m_j) | |||
| e_init = partial_sum * e_delta_max | |||
| d_j = tkw.sum(e_delta, e_init, dim=N_KV) | |||
| imm_f16 = tkw.cast(e_delta, wave_input_dtype) | |||
There was a problem hiding this comment.
I think we should also keep this as imm_f16 = tkw.cast(e_delta, wave_input_dtype) just because we may have bf16 inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.