-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection of QoL changes #432
Open
GMNGeoffrey
wants to merge
5
commits into
iree-org:main
Choose a base branch
from
GMNGeoffrey:misc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bad PR in the sense that it does a bunch of different things. This is a collection of changes I made, mostly around improving debugging with more verbose and specific error messages. But there's also some other stuff in here. Most of these don't really seem sufficiently important to break out into their own PR, but it seemed a shame to just throw away things that seemed like improvements. I did try to clean things up a bit to make them actually upstreamable. One note is that I'm not really sure what the convention is for Exception types in the project, so a lot of these are just RuntimeError. That's not awesome, but I think it's still a lot more helpful than nothing.
Sorry, should've run tests after doing cleanup, obviously.... |
I know it can get quite long, but would be lovely if we have the list of fixes on the PR message |
There's still something suspicious going on with the index for reduction ops, but my change causes breakage, so reverting it.
This requires changing too many tests to be part of this PR. Will try to submit separately.
I'm not sure that this is correct. I hit some weird thing here, but this may not be the fix.
I removed some of the more substantive changes, fixed the test failures, and wrote down more detail about the changes. |
I added these while debugging the test failures from this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bad PR in the sense that it does a bunch of different things, but they're all pretty small. This is a collection of changes I made while developing kernels, mostly around improving debugging with more verbose and specific error messages. Most of these don't really seem sufficiently important to break out into their own PR, but it seemed a shame to just throw away things that seemed like improvements. I did try to clean things up a bit to make them actually upstreamable.
Changes:
__str__
method for IndexingContext and__repr__
methods toExpansionInfo
andReductionInfo
. Maybe these should be data classes?tkw.reshape
CapturedTrace.walk
optional (if None, just returns all nodes)KeyError
into more specific error messages with contextget_custom
is passed an op an error instead. I think this more likely than not points to a bug, so it's better for it to be an error. I can't remember the specific case in which I hit it.m
has to be inlhs
andn
inrhs
. Locally, I actually have much more restrictive validation that lhs had to be[..., m, k]
and rhs[..., n, k]
. In theory it looks like Wave is supposed to figure things out if that isn't the setup, but I never had a case where it actually worked, so it seems like you need walk some narrow path. This version is the less restrictive one though.get_users
testBatchedGemm
One note is that I'm not really sure what the convention is for Exception types in the project, so a lot of these are just RuntimeError. That's not awesome, but I think it's still a lot more helpful than nothing. I tried to avoid
raise ... from
as in my experience these usually result in unhelpfully verbose stacks.Let me know if you'd like me to do this differently, there are any of these changes that you think warrant more discussion, or you don't think they're worth this grab bag PR. If this doesn't land before I head off, feel free to modify into something uncontroversial and merge.