Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further reduce org owners/admins #69

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Further reduce org owners/admins #69

merged 2 commits into from
Feb 16, 2024

Conversation

BigLep
Copy link
Contributor

@BigLep BigLep commented Feb 16, 2024

Summary

Followup to #68 to further reduce org owners/admins based on where have been landing in ipfs/ipfs#511.

No worries if IPLD doesn't want to go to this extreme - this can be abandoned.

If this approved, after merging, the following steps will need to be taken:

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipld

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_membership.this["aschmahmann"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "ipld:aschmahmann"
      ~ role     = "admin" -> "member"
        # (2 unchanged attributes hidden)
    }

  # github_membership.this["rvagg"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "ipld:rvagg"
      ~ role     = "admin" -> "member"
        # (2 unchanged attributes hidden)
    }

  # github_membership.this["vmx"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "ipld:vmx"
      ~ role     = "admin" -> "member"
        # (2 unchanged attributes hidden)
    }

  # github_team_membership.this["github-mgmt stewards:aschmahmann"] will be updated in-place
  ~ resource "github_team_membership" "this" {
        id       = "6630960:aschmahmann"
      ~ role     = "maintainer" -> "member"
        # (3 unchanged attributes hidden)
    }

  # github_team_membership.this["github-mgmt stewards:rvagg"] will be updated in-place
  ~ resource "github_team_membership" "this" {
        id       = "6630960:rvagg"
      ~ role     = "maintainer" -> "member"
        # (3 unchanged attributes hidden)
    }

  # github_team_membership.this["github-mgmt stewards:vmx"] will be updated in-place
  ~ resource "github_team_membership" "this" {
        id       = "6630960:vmx"
      ~ role     = "maintainer" -> "member"
        # (3 unchanged attributes hidden)
    }

Plan: 0 to add, 6 to change, 0 to destroy.

@BigLep
Copy link
Contributor Author

BigLep commented Feb 16, 2024

Cc @aschmahmann , @rvagg , @vmx since this is removing you as org owners (but still keeping you as github-mgmt stewards). The rationale and permissions exploration was done in ipfs/ipfs#511 (comment)

- rvagg
# Why @vmx?
# 1. Continued IPLD maintainer since the pre-2021 days of an "IPLD core team", working across both JS and Rust repos.
# 2. Owner of important IPLD community touch points like monthly community calls.
Copy link
Member

@vmx vmx Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: I misunderstood how things work, now that I do, it's what I've asked for, so all good. Below is my original message which doesn't really apply anymore.


Sadly those calls are not a thing anymore.

Also I don't really need to be an admin as long as there's some easy way to get things done in case I need something (knowing who to ping is what I consider easy). I'm in favour of having as little admins as it's useful. I don't see it as something "taken away" from me, it just makes sense from an opsec perspective.

Unless you want me as a person that can be pinged and do things, I'm also happy to fill that role for IPLD.

@BigLep
Copy link
Contributor Author

BigLep commented Feb 16, 2024

@galargh : I think we're good to have you merge given there is approval here.

Copy link
Contributor

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving & merging since initial approvals were received - thank you @BigLep for driving the initiative.

As a reminder to everyone, any changes made through GitHub Management are always reversible - in particular, GitHub Management Stewards can always apply any change (e.g. reinstate the org admins) themselves.

@galargh galargh merged commit 1c1b01e into ipld:master Feb 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants