feat(css): add support for the subtle color map #30306
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| ), | ||
| // neutral/base equivalent | ||
| light: |
There was a problem hiding this comment.
I think we should probably make light use a lighter version but I am not sure
There was a problem hiding this comment.
Looking at the Colors page, I think is already light enough and different form Medium and Dark, I'm ok with this :)
| contrast-rgb: globals.$ion-text-default-rgb, | ||
| // TODO this fails AA testing | ||
| // shade: globals.$ion-bg-neutral-base-press, | ||
| shade: globals.$ion-primitives-neutral-600, |
There was a problem hiding this comment.
The 600 token is one step lighter but it fails AA with default text
There was a problem hiding this comment.
Maybe use --ion-color-dark-subtle-contrast or --ion-bg-neutral-bold-press?
There was a problem hiding this comment.
The bg-neutral-bold-press token is too dark for this, it uses #242424 compared to the current token I am using #8c8c8c. I couldn't find any tokens with “dark” in their name. The issue is the light color is using the default (black) text so the pressed state can't be too dark to not fail the contrast check.
brandyscarney
requested review from
christian-bromann and
BenOsodrac
and removed request for
christian-bromann
Issue number: internal
What is the current behavior?
The colors are only available in bold colors.
What is the new behavior?
Adds support for a
subtlehue to the colors map, generating all of the same variants but in more subtle colors. This only applies for theionictheme. Adds an additional variant,foregroundto be used by components when the color is being used for text.The
iosandmdthemes do not add theforegroundvariant because this would be a breaking change, requiring all color overrides, palettes, and new colors to include this variant. I have added tests to make sure they still work without it.Does this introduce a breaking change?
No changes are made to the existing colors.
Other information
Preview