Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(app, expo): Google sign in and Expo doc correction #8389

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SKempin
Copy link

@SKempin SKempin commented Mar 5, 2025

Description

Correcting confusing documentation regarding Google sign in and Expo. See react-native-google-signin/google-signin#1364 (comment)

The docs currently indicate the GoogleSignin.configure is not required with Expo, however it is.

Related issues

react-native-google-signin/google-signin#1364

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • This is a breaking change;
    • Yes
    • No

Correcting confusing documentation regarding Google sign in and Expo. See react-native-google-signin/google-signin#1364 (comment)
Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 6:04pm

@CLAassistant
Copy link

CLAassistant commented Mar 5, 2025

CLA assistant check
All committers have signed the CLA.

@SKempin SKempin changed the title Google sign in and Expo doc correction. docs: Google sign in and Expo doc correction. Mar 5, 2025
@SKempin SKempin changed the title docs: Google sign in and Expo doc correction. docs(app, expo): Google sign in and Expo doc correction Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants