fix(database): Type definitions #8373
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| */ | ||
| export function serverTimestamp() { | ||
| return firebase.database.ServerValue.TIMESTAMP; | ||
| export function getServerTime(db) { |
There was a problem hiding this comment.
why two functions instead of having the first one check if db === undefined, followed by each branch doing the right thing? That idiom is already in a lot of the code, for what it's worth
| @@ -220,5 +220,13 @@ export function getServerTime(db: Database): Promise<number>; | |||
| */ | |||
| export function increment(delta: number): object; | |||
|
|
|||
| /** | |||
| * Logs debugging information to the console. | |||
There was a problem hiding this comment.
if it is not implemented, there should be some indication of why in the docs, also, perhaps not implemented native but is there any reason not to plumb it through for web?
| @@ -239,6 +239,10 @@ export function get(query) { | |||
| return query.once('value'); | |||
| } | |||
|
|
|||
| export function off(query, eventType, callback) { | |||
| throw new Error("off() is not implemented"); | |||
There was a problem hiding this comment.
similar to enableLogging - if it is not implemented it seems that should be noted in the docs for the method in query.d.ts? And also same as enableLogging, any reason not to plumb it through on web/other implementation (if it is not already)
Description
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter