Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(melos): updated dependencies to latest stable versions #618

Closed
wants to merge 3 commits into from
Closed

chore(melos): updated dependencies to latest stable versions #618

wants to merge 3 commits into from

Conversation

OutdatedGuy
Copy link

Description

Updated packages file and pub_updater to latest stable versions i.e. v7.0.0 and v0.4.0 respectively.

Also updated dependency versions in the melos.yaml file to properly bootstrap melos while using melos bootstrap.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

Copy link

docs-page bot commented Dec 21, 2023

To view this pull requests documentation preview, visit the following URL:

melos.invertase.dev/~618

Documentation is deployed and generated using docs.page.

@CLAassistant
Copy link

CLAassistant commented Dec 21, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not pass the dependency constraints.

This supports upgrading dependency to breaking versions/changes
@OutdatedGuy OutdatedGuy requested a review from spydon December 22, 2023 12:21
Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this change gives us anything, it will be more work maintaining those dependency ranges. It's better to wait with bumping these dependencies until we bump Dart.

@OutdatedGuy
Copy link
Author

Yo @spydon, this is the same tactic we used while updating the http package in this commit.

Also because of these constraints, I'm unable to add melos as I'm using packages with the latest versions of pub_updater and file.

Additionally, we can later remove the range after the current melos is updated.

@spydon
Copy link
Collaborator

spydon commented Dec 22, 2023

Yo @spydon, this is the same tactic we used while updating the http package in this commit.

Also because of these constraints, I'm unable to add melos as I'm using packages with the latest versions of pub_updater and file.

Additionally, we can later remove the range after the current melos is updated.

The dependencies of Melos should not affect your usage of it? If you have a package/app in the root I recommend that you move it into a sub-directory, for example packages/ for packages or apps/ for apps, because you shouldn't share the Melos workspace pubspec with it.

@OutdatedGuy OutdatedGuy closed this by deleting the head repository Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants