Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the dotnet template to follow the github intility path #387

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

Update the dotnet template to follow the github intility path #387

wants to merge 43 commits into from

Conversation

loekensgard
Copy link
Member

@loekensgard loekensgard commented Feb 11, 2025 •
edited
Loading

Bulletpoints

  • Update to .net 9
  • Remove old setup (helm, gitlab-ci, dockerfiles)
  • Group template parameters
  • Add multiproject support (api and test)
  • Add Github workflow
  • Add dependabot
  • Add k8s setup
  • Add argo setup
  • Rework documentation

New Features

  • Utilizes Containerize csproj
  • Added GitHub Actions with a reusable workflow from Intility
  • Added multi-project support for API, including an API csproj and a test csproj
  • Integrated Dependabot to check for NuGet and GitHub Action updates
  • Transitioned from Helm to Kustomize
  • Implemented Argo setup

Questions

  • Should we implement release-please?
    • Yes, done
  • Should we implement a .editorconfig?
    • Yes, done. Also .gitattributes

@loekensgard loekensgard changed the title Update the dotnet template to follow work with github Update the dotnet template to follow the github intility path Feb 12, 2025
@loekensgard
Copy link
Member Author

loekensgard commented Feb 12, 2025 •
edited
Loading

@h3rmanj do you want to take a look at the k8s setup? I added some default files, and uses a derived app name (ContainerRepositoryPlaceholder) as replacement values for naming. This should be a safe string value, but I have not tested it.

@loekensgard loekensgard self-assigned this Feb 12, 2025
@loekensgard loekensgard added enhancement New feature or request dotnet .NET templates labels Feb 12, 2025
@loekensgard
Copy link
Member Author

I'm finished with a first crack at the new dotnet template, without updating any doc. Also, not tested the github, argo and kustomize setup yet.

@loekensgard loekensgard marked this pull request as ready for review February 13, 2025 08:32
h3rmanj
h3rmanj reviewed Feb 26, 2025
View reviewed changes
Copy link
Member

@h3rmanj h3rmanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • consider release-please
  • consider commented out argo apps for prod, qa and review deployments
  • what happens when you add a project to a solution? (kustomize files etc)
  • route/ingress

loekensgard and others added 18 commits February 26, 2025 14:57
@loekensgard
fix: add params to specify deployment configuration
23483d1
@loekensgard
fix: set revisionHistoryLimit: 0
5d08a04
@loekensgard
fix: remove revisionHistoryLimit: 0 from cronJon
4a097f7
@loekensgard
fix: add ingress instead of route, move resouces to the top
4e84937
@loekensgard
fix: change internal visible path
a7cae3d
@loekensgard
fix: add correct name to tests
34a18a0
@loekensgard
fix: add kebabCase and overrides for argo name, openshift namespace a…
aea4945 
…nd github repo
@h3rmanj @loekensgard
fix: add source maps to dockerignore
5deadb0
@loekensgard
feat: add release-please config
55d6a66
@loekensgard
feat: add editorconfig and gitattributes
fa5ccc4
@loekensgard
feat: add prod argo yaml
6686022
@loekensgard
fix: use dotnet 9 for dotnet pack
ddadeca
@loekensgard
fix: exclude solution files if project
6446b94
@loekensgard
fix: disable k8s params if project only
7e4821e
@loekensgard
fix: remove domain and instance from params
e0b69af
@loekensgard
docs: rewrite the .net doc to work with github
f1e77f4
@loekensgard
fix: add release please workflow
730643b
@loekensgard
build: update dependencies
307d8ed
daniwk
daniwk approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@daniwk daniwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. An improvement in the future should be to use the sha commit instead of tag in production.

@loekensgard loekensgard requested a review from h3rmanj March 3, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniwk daniwk daniwk approved these changes

@h3rmanj h3rmanj Awaiting requested review from h3rmanj

Assignees

@loekensgard loekensgard

Labels
dotnet .NET templates enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loekensgard @h3rmanj @daniwk