feat: implement configurable API key storage #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce an APIKeyStorage interface with two concrete implementations: KeyringAPIKeyStorage and FileAPIKeyStorage. The FileAPIKeyStorage implementation is first of all intended for WSL2 environments where keyring does not work that well, so temporarly storing to the file-system is the most user-friendly option. The ResolveAPIKeyStorage function resolves which storage mechanism to use. If the system is WSL2, automatically use FileAPIKeyStorage. Refactor config package to align with the new storage mechanism.
|
Hello @nkzk, Thank you for your contribution! Your work is a great step towards enhancing the versatility of cwc, enabling it to function seamlessly across a wider range of environments. However, I must inform you that some recent updates have led to merge conflicts with your pull request. The silver lining is that these updates actually simplify the integration of your feature by leveraging the existing Would you prefer to update your pull request to resolve these conflicts, or would you rather wait and revisit your contribution later? I apologize for the inconvenience caused by these unforeseen changes that have affected your pull request. |
|
I'll resolve the merge conflict and pull it in, thanks @nkzk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an APIKeyStorage interface with two concrete implementations: KeyringAPIKeyStorage and FileAPIKeyStorage.
The FileAPIKeyStorage implementation is first of all intended for WSL2 environments where keyring does not work that well, so temporarly storing to the file-system is the most user-friendly option.
The ResolveAPIKeyStorage function resolves which storage mechanism to use. If the system is WSL2, automatically use FileAPIKeyStorage.
Refactor config package to align with the new storage mechanism.