Display error message when Google sign-in fails during account registration

[jimchamp]

Closes #10404

Updates code such that an error message is displayed whenever a Google sign-in attempt fails during account registration.

Technical

The client-side third-party authentication code handles errors by displaying an error message in a new div, which is attached to the DOM relative to an element with id register.

openlibrary/openlibrary/plugins/openlibrary/js/ia_thirdparty_logins.js

Lines 31 to 37 in 45a0122

	.then((error) => {
	const loginForm = document.querySelector('#register')
	const errorDiv = document.createElement('div')
	errorDiv.classList.add('note')
	errorDiv.textContent = error.errorDisplayString
	loginForm.insertAdjacentElement('afterbegin', errorDiv)
	})

Potential Follow-up Items

It might be nice to use a single template for the login and sign-up pages. The existing templates for each are largely identical, and combining them would give us an opportunity to clean up some of the confusing class and id names. For example:

Class name on login page is ol-page-signup

openlibrary/openlibrary/templates/login.html

Line 22 in 45a0122

<div class="ol-page-signup">

ID on login form is register

openlibrary/openlibrary/templates/login.html

Line 38 in 45a0122

<form id="register" class="login olform" name="login" method="post" data-i18n="$json_encode(i18n_strings)">

Testing

Screenshot

Stakeholders