replaced push_scope with new_scope in sentry.py #10416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
jimchamp
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Thanks @R0gue-one! Have confirmed that these changes are working in our testing environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10381
This PR is a
fixTechnical
Replaced the depreciated
sentry_sdk.push_scopewithsentry_sdk.new_scopein openlibrary/utils/sentry.pyI have replaced
sentry_sdk.push_scopecalls hereTesting
Can view changed files to verify the changes.
No behavioural changes are expected as this is just updating to the new recommended Sentry SDK method.
Stakeholders
@jimchamp @mekarpeles