Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display autocomplete results on search facet change #10415

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Spaarsh
Copy link
Contributor

@Spaarsh Spaarsh commented Feb 1, 2025

Closes #10359

fix

Technical

It changes the JS handler for displaying the autocomplete results.

Testing

  1. Search for any keyword in the search bar.
  2. Change the facet, if the autocomplete results for that facet are displayed, the PR works as expected.

Screenshot

autocomplete-demo.webm

Stakeholders

@RayBB

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.52%. Comparing base (3025f5d) to head (d33f656).
Report is 312 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10415      +/-   ##
==========================================
+ Coverage   17.44%   17.52%   +0.07%     
==========================================
  Files          89       87       -2     
  Lines        4792     4793       +1     
  Branches      848      852       +4     
==========================================
+ Hits          836      840       +4     
+ Misses       3436     3431       -5     
- Partials      520      522       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RayBB
Copy link
Collaborator

RayBB commented Feb 1, 2025

I will test it this week. Please add a descriptive PR title in the meantime :)

@Spaarsh Spaarsh changed the title Fixes 10359 Display autocomplete results on search facet change Feb 2, 2025
@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Feb 11, 2025
Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and it's working great. I'll try to review with staff this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
Status: Waiting Review/Merge from Staff
Development

Successfully merging this pull request may close these issues.

Show autocomplete results when you change the search type
3 participants