Fix single double quote breaking solr query

[tomrod10]

Closes #10390

Searching with an unmatched double quote ", causes the Solr query to be invalid/break.

On line 484 in ~/openlibrary/plugins/worksearch/schemes/works.py it looks like it escapes already escaped ". Therefore turning the string:
'Compilation Group for the \\"History of Modern China' into 'Compilation Group for the \\\\"History of Modern China'.

I edited the code on line 484 to only escape " if \\" is not in the ed_q string. Otherwise, either all " will be escaped if ed_q is not falsy, else the kwarg v will be set to *:*.

Technical

Testing

Added tests:

• ~/openlibrary/plugins/worksearch/schemes/tests/test_works.py

Manual testing:

• Searched words and phrases with a single or an odd count of "
• Checked that the query results in a 200 OK response

Screenshot

Stakeholders

@cdrini

[tomrod10]

The following tests are failing:

• openlibrary/plugins/worksearch/schemes/tests/test_works.py::test_process_user_query[Spaces after fields]
• openlibrary/plugins/worksearch/schemes/tests/test_works.py::test_process_user_query[Quotes]
• openlibrary/plugins/worksearch/schemes/tests/test_works.py::test_process_user_query[LCC: quotes preserved]

[tomrod10]

Probably will move my test to tests/test_works.py and delete tests/test_SearchScheme.py

[cdrini]

I spent some time researching/debugging this one, and I think I found a better solution.

Escaping the " to embed it in the larger edismax query is potentially a bit of a security risk, since if we don't escape it correctly, a user could effectively run any complicated query on our solr!

We can avoid escaping it to embed in the edismax query entirely, if we take advantage of a solr feature that lets us put edismax parameters in separate url params. E.g.

?q={!edismax v=$someParam}
&someParam=users raw "query

Testing this out on testing now...

[cdrini]

Hit one issue about editions.q having a different scope for the template query parameters (?!?!) but appears to be working now!

Great work on finding the root cause of this @tomrod10 !