-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opposite direction arrow button for Omnibar #10315
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10315 +/- ##
==========================================
+ Coverage 17.44% 17.57% +0.12%
==========================================
Files 89 88 -1
Lines 4792 4775 -17
Branches 848 849 +1
==========================================
+ Hits 836 839 +3
+ Misses 3436 3415 -21
- Partials 520 521 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, great work @Craig-Rosario ! Tested on testing and works like a charm!
As an improvement for a future issue: we should only show the left arrow if we're not at the far-left. Similarly, the right arrow should also disappear if we're at the end.
Thanks @cdrini, |
Closes #10240
Opposite direction arrow button for Omnibar:
Technical
Testing
1)Go to any book page (eg. https://openlibrary.org/works/OL69166W/Italian_journeys)
2)Resize the screen and see the arrow only for one direction
Screenshot/Video
Video of implementation:
new.arrow.mp4
Screenshot:

Stakeholders
@cdrini