Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No error message is displayed when Google sign-in fails on the registration page #10404

Closed
jimchamp opened this issue Jan 30, 2025 · 3 comments · Fixed by #10436
Closed

No error message is displayed when Google sign-in fails on the registration page #10404

jimchamp opened this issue Jan 30, 2025 · 3 comments · Fixed by #10436
Assignees
@jimchamp
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 2 Important, as time permits. [managed] registration Type: Bug Something isn't working. [managed]

Comments

@jimchamp
Copy link
Collaborator

Problem

The code that handles Google OAuth failures displays errors in a new div, which is inserted next to an element with id="register". Such a div appears on the account login page, but not the registration page.

Reproducing the bug

  1. Go to ...
  2. Do ...
  • Expected behavior:
  • Actual behavior:

Context

  • Browser (Chrome, Safari, Firefox, etc):
  • OS (Windows, Mac, etc):
  • Logged in (Y/N):
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders

Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@jimchamp jimchamp added Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Jan 30, 2025
@jimchamp jimchamp mentioned this issue Jan 30, 2025
Merged
@prasad14070
Copy link

Hello @jimchamp , I would like to contribute on this issue.

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Feb 3, 2025
@cdrini cdrini added registration Priority: 2 Important, as time permits. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Feb 3, 2025
@jimchamp
Copy link
Collaborator Author

jimchamp commented Feb 5, 2025

Thanks @prasad14070!

Before making code changes, can you help us with breakdown by:

  1. Clarifying what you believe the task to be
  2. Identifying which files are related to the issue
  3. Asking any questions you may have about the goal or requirements of this issue
  4. Proposing a solution or approach

@jimchamp jimchamp removed the Needs: Response Issues which require feedback from lead label Feb 5, 2025
@jimchamp jimchamp self-assigned this Feb 10, 2025
@jimchamp
Copy link
Collaborator Author

Assigning myself, as this is causing problems for patron services.

@jimchamp jimchamp mentioned this issue Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimchamp jimchamp

Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 2 Important, as time permits. [managed] registration Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display error message when Google sign-in fails during account registration jimchamp/openlibrary
3 participants
@cdrini @jimchamp @prasad14070