Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make QueryCarousels edition-aware #7252

Open
Tracked by #9828
cdrini opened this issue Dec 9, 2022 · 3 comments · May be fixed by #10362 or #7295
Open
Tracked by #9828

Make QueryCarousels edition-aware #7252

cdrini opened this issue Dec 9, 2022 · 3 comments · May be fixed by #10362 or #7295
Labels
Fellowship Opportunity Good First Issue Easy issue. Good for newcomers. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Solr Issues related to the configuration or use of the Solr subsystem. [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Priority: 2 Important, as time permits. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Milestone
Sprint 2025-02

Comments

@cdrini
Copy link
Collaborator

cdrini commented Dec 9, 2022 •
edited by mekarpeles
Loading

Originally raised by @seabelis before we had editions in solr in #5858:
Screenshot 2025-01-14 at 2 49 37 PM

Currently creating collection carousels only displays works. This can be limiting for folks who want to create collections in languages other than English (in most cases) or who want to feature specific covers, i.e. movie-tie ins, specific publisher collections (i.e. Penguin Classics)...

Problem

When carousels are work-only, the work cover we show may match the language or availability of whatever edition the patron gets routed to.

There are several situations where the current work-based carousels are limited:

  • Querying for and showing specific editions of a certain language
  • Querying for and showing specific editions by a certain e.g. publisher

Goal

QueryCarousels should be able to match editions where possible so that the patron can rely on its books being advertised in the right language and with the right availability.

Why now

We already have the ability to feature editions on our search page since #6377 landed in 2022. There's also a PR #7295 that implements a partial solution
This was referenced Dec 9, 2022
Closed
Open
@cdrini cdrini added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Theme: Search Issues related to search UI and backend. [managed] Priority: 2 Important, as time permits. [managed] labels Dec 13, 2022
This was referenced Dec 14, 2022
Open
Closed
Draft
@cdrini cdrini mentioned this issue Dec 24, 2022
Closed
@cdrini cdrini self-assigned this Jan 25, 2023
@cdrini
Copy link
Collaborator Author

cdrini commented Jun 5, 2024 •
edited
Loading

This work is partially implemented in #7295 ; if a fellow is interested in rebasing this branch, with some testing/cleanups, should be enough to make this happen!

@cdrini cdrini changed the title Use editions in solr for carousels Make QueryCarousels edition-aware Jun 12, 2024
@mekarpeles mekarpeles mentioned this issue Aug 29, 2024
Open
6 tasks
@mekarpeles mekarpeles added the Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] label Jan 14, 2025
@mekarpeles mekarpeles added this to the Sprint 2025-02 milestone Jan 14, 2025
@mekarpeles mekarpeles mentioned this issue Jan 14, 2025
Closed
@mekarpeles mekarpeles added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Module: Solr Issues related to the configuration or use of the Solr subsystem. [managed] Good First Issue Easy issue. Good for newcomers. [managed] labels Jan 14, 2025
@mekarpeles
Copy link
Member

I'm not positive this is a good first issue, though we'd love someone to try to push #7295 over the finish line as this is a high impact feature which will make a big difference for patrons!

@jimchamp jimchamp linked a pull request Jan 22, 2025 that will close this issue
Open
@jimchamp
Copy link
Collaborator

@cdrini, what is needed to complete #7295? Is it just a rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fellowship Opportunity Good First Issue Easy issue. Good for newcomers. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Solr Issues related to the configuration or use of the Solr subsystem. [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Priority: 2 Important, as time permits. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Milestone
Sprint 2025-02
3 participants
@mekarpeles @cdrini @jimchamp