Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to prefer a provider in a search carousel #5992

Closed
Tracked by #5792
cdrini opened this issue Dec 20, 2021 · 9 comments
Closed
Tracked by #5792

Add option to prefer a provider in a search carousel #5992

cdrini opened this issue Dec 20, 2021 · 9 comments
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 2 Important, as time permits. [managed] Theme: Trusted Book Providers Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Dec 20, 2021

Subtask of #5792

Currently, carousels on collection pages (e.g. https://openlibrary.org/collections/hugo-awards ) cannot specify a preferred book provider (e.g. prefer librivox audiobooks). This will let us do that! Note we can already use the providerPref url parameter in a search; e.g. https://openlibrary.org/search?q=publisher%3Alibrivox&mode=everything&providerPref=librivox ; we just need this to be exposed to QueryCarousel.

Expected usage:

{{QueryCarousel('publisher:librivox', provider_pref='librivox', has_fulltext_only=False)}}

Related files

@cdrini cdrini mentioned this issue Dec 20, 2021
53 tasks
@cdrini cdrini added Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 2 Important, as time permits. [managed] Theme: Trusted Book Providers Good First Issue Easy issue. Good for newcomers. [managed] labels Dec 21, 2021
@tuminzee
Copy link
Collaborator

I would like to work on this issue

@cdrini cdrini added the Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] label Dec 21, 2021
@cdrini
Copy link
Collaborator Author

cdrini commented Dec 21, 2021

Awesome! Let me know if have any questions :)

@cdrini
Copy link
Collaborator Author

cdrini commented Dec 21, 2021

I think all the changes that need to be made should be in the QueryCarousel.html file 👍

@tuminzee
Copy link
Collaborator

I will try to finish this before holidays.
Thank you for your help, and prompt reply 🕺

@cdrini
Copy link
Collaborator Author

cdrini commented Dec 21, 2021

Ooooh, heads up I think this might actually be quite a bit more complicated 😅 it might need changes to a few different spots. Be warned ; if it looks like it's getting complicated, bring it up 👍

@tuminzee
Copy link
Collaborator

Perfect, I'll try my best 🕺👨‍💻

@cdrini
Copy link
Collaborator Author

cdrini commented Feb 14, 2022

We determined that this is probably better to do after #2064 , so removing good first issue. Thanks for your patience, @tuminzee !

@cdrini cdrini removed Good First Issue Easy issue. Good for newcomers. [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] labels Feb 14, 2022
@tuminzee
Copy link
Collaborator

Thank you @cdrini for your patience 👯

@tuminzee tuminzee added Needs: Response Issues which require feedback from lead and removed Needs: Response Issues which require feedback from lead labels Feb 15, 2022
@cdrini
Copy link
Collaborator Author

cdrini commented Dec 24, 2022

Replaced by #7252

@cdrini cdrini closed this as completed Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 2 Important, as time permits. [managed] Theme: Trusted Book Providers Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed]
Projects
None yet
Development

No branches or pull requests

2 participants