-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate TtsPlugin to BookReaderPlugin #1376
Open
cdrini
wants to merge
9
commits into
internetarchive:master
Choose a base branch
from
cdrini:refactor/tts-br-plugin
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1376 +/- ##
==========================================
- Coverage 69.25% 69.22% -0.03%
==========================================
Files 60 60
Lines 5135 5150 +15
Branches 1087 1102 +15
==========================================
+ Hits 3556 3565 +9
- Misses 1550 1555 +5
- Partials 29 30 +1 ☔ View full report in Codecov by Sentry. |
- Breaking change: TTS `server` and `bookPath` options replaced with `pageChunkUrl` StringWithVars
c292184
to
9a2e689
Compare
The threshold field is already in percentage, it doesn't need to be /100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #1374 , so ignore the autoplay files in this diff
Breaking Changes:
BookReader#ttsToggle
,BookReader#ttsScrollToChunk
,BookReader#ttsStart
, etc, have all been moved to e.g.br._plugins.tts.toggle
. That is they are now on theTtsPlugin
class, and no longer have thetts
as inttsStart
.enableTtsPlugin
has been renamed toplugins.tts.enabled
server
andbookPath
have been replaced withpageChunkUrl
StringWithVars. This makes the page chunk URL configurable for other clients.