Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ResumePlugin to BookReaderPlugin #1375

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cdrini
Copy link
Contributor

@cdrini cdrini commented Feb 1, 2025

Blocked by #1374 , so ignore the autoplay files in this diff.

Testing:

  1. Go to the netlify review app https://deploy-preview-1375--lucid-poitras-9a1249.netlify.app/bookreaderdemo/demo-internetarchive?ocaid=theworksofplato01platiala
  2. Go to a page
  3. Remove the #... fragment from the url and reload the page
  4. ✅ Should be sent back to the same page

Breaking changes:

  • BookReader#getResumeValue() moved to BookReader._plugins.resume.getResumeValue(). Similarly for getCookiePath, and updateResumeValue .
  • The option enablePageResume: bool has been renamed to plugins.resume.enabled: bool
  • The option resumeCookiePath: string has been renamed to plugins.resume.cookiePath: string

@cdrini cdrini added the blocked label Feb 1, 2025
@cdrini cdrini force-pushed the refactor/resume-br-plugin branch from 8bc0107 to d7bd63d Compare February 1, 2025 01:33
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 76.08696% with 22 lines in your changes missing coverage. Please review.

Project coverage is 69.21%. Comparing base (c067962) to head (44d12df).

Files with missing lines Patch % Lines
src/plugins/plugin.autoplay.js 70.83% 14 Missing ⚠️
src/BookReader.js 73.68% 5 Missing ⚠️
src/BookReader/Mode2UpLit.js 0.00% 2 Missing ⚠️
src/plugins/url/plugin.url.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1375      +/-   ##
==========================================
- Coverage   69.25%   69.21%   -0.04%     
==========================================
  Files          60       60              
  Lines        5135     5146      +11     
  Branches     1087     1102      +15     
==========================================
+ Hits         3556     3562       +6     
- Misses       1550     1555       +5     
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdrini cdrini force-pushed the refactor/resume-br-plugin branch from d7bd63d to 44d12df Compare February 1, 2025 01:56
@cdrini cdrini marked this pull request as ready for review February 1, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant