Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refactor diagnosis system #1475

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

samplise
Copy link
Collaborator

What changes were proposed in this pull request?

Refactor the diagnosis system according to the new design.

Why are the changes needed?

Make it simpler to implement problem diagnosis in the DLRover.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Unit test.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 78.50467% with 23 lines in your changes missing coverage. Please review.

Project coverage is 82.72%. Comparing base (774fa01) to head (dbb4b33).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...er/python/diagnosis/diagnostician/diagnostician.py 60.00% 18 Missing ⚠️
...gnosis/diagnostician/failure_node_diagnostician.py 90.32% 3 Missing ⚠️
...lrover/python/diagnosis/common/diagnosis_action.py 90.90% 1 Missing ⚠️
.../python/elastic_agent/diagnosis/diagnosis_agent.py 94.11% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (78.50%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1475      +/-   ##
==========================================
- Coverage   82.72%   82.72%   -0.01%     
==========================================
  Files         257      259       +2     
  Lines       26314    26422     +108     
==========================================
+ Hits        21769    21858      +89     
- Misses       4545     4564      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant