[CI]Split XPU distributed UT into another job #1371
+132
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuanqi129
requested changes
Feb 18, 2025
.github/workflows/pull.yml
Outdated
| @@ -233,6 +221,31 @@ jobs: | |||
| ut: op_extended | |||
| runner: linux.idc.xpu | |||
|
|
|||
| preci-linux-build-distributed: | |||
There was a problem hiding this comment.
remove this job, we don't need 2 builds
zxd1997066
force-pushed
the
xiangdong/split_ddp
branch
3 times, most recently
from
e191aaf to
cc2b42b
Compare
|
Please add |
zxd1997066
force-pushed
the
xiangdong/split_ddp
branch
3 times, most recently
from
332ce7b to
a426c25
Compare
chuanqi129
reviewed
Feb 21, 2025
.github/workflows/_linux_ut.yml
Outdated
| path: ${{ github.workspace }}/ut_log | ||
|
|
||
| distributed_ut_test: | ||
| runs-on: ${{ inputs.runner }} |
There was a problem hiding this comment.
let's hardcode the distributed runner as pvc_e2e
.github/workflows/_linux_ut.yml
Outdated
| @@ -49,6 +49,7 @@ permissions: read-all | |||
| jobs: | |||
| ut_test: | |||
| runs-on: ${{ inputs.runner }} | |||
| if: contains(inputs.ut, 'xpu_distributed') == false | |||
There was a problem hiding this comment.
Suggested change
| if: contains(inputs.ut, 'xpu_distributed') == false | |
| if: ${{ inputs.ut != 'xpu_distributed' }} |
|
add |
zxd1997066
force-pushed
the
xiangdong/split_ddp
branch
2 times, most recently
from
1eda649 to
80b8447
Compare
chuanqi129
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.