FloatingPointValue refactor for simpler resuable construction #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in random generation
desmonddak
reviewed
Feb 21, 2025
desmonddak
reviewed
Feb 21, 2025
lib/src/arithmetic/values/floating_point_values/floating_point_value.dart
Show resolved
Hide resolved
desmonddak
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Major refactor of
FloatingPointValueto remove factory constructors and put automation related to construction into "populators".Related Issue(s)
N/A
Testing
Existing tests cover most of it, plus some new ones to cover additional functionality
Backwards-compatibility
Not relative to a released version of ROHD-HCL, but a major set of backwards-incompatible changes relative to what was previously on
mainDocumentation
Yes, included