fix model save config #639
Merged
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MayureshV1
reviewed
Apr 4, 2025
vthaniel
force-pushed
the
saurabh/model_save
branch
from
c93a645 to
9d0367a
Compare
saurabhkale17
force-pushed
the
saurabh/model_save
branch
from
9561f4a to
c972758
Compare
saurabhkale17
requested review from
ankitm3k,
preetha-intel,
vthaniel,
jatinwadhwa921 and
javier-intel
javier-intel
reviewed
Apr 8, 2025
| static void DumpOpenVINOEPModel([[maybe_unused]] const std::filesystem::path& onnx_model_path_name, | ||
| [[maybe_unused]] ONNX_NAMESPACE::ModelProto* model_proto, | ||
| [[maybe_unused]] const onnxruntime::Node& fused_node) { | ||
| #ifdef NOT_RELEASE |
There was a problem hiding this comment.
Can we rename this definition NOT_RELEASE
Lets have a macro for RELEASE
target_compile_options(onnxruntime_providers_openvino PRIVATE
$<$<CONFIG:Release>:-DRELEASE>
)
#ifndef RELEASE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Limit the ability to save stripped model in disk using ORT_OPENVINO_ENABLE_DEBUG flag only in Debug and RelWithDebInfo builds.