Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device type refactoring #630

Merged
merged 5 commits into from
Apr 4, 2025
Merged

Conversation

preetha-intel
Copy link

@preetha-intel preetha-intel commented Mar 28, 2025

Hi. The PR handles the following JIRA's
https://jira.devtools.intel.com/browse/CVS-165227
https://jira.devtools.intel.com/browse/CVS-164697
https://jira.devtools.intel.com/browse/CVS-165140

These scenarios needs to be validated

For LUID testing,
get the luid of device using python openvino snippet ,
import openvino as ov
core = ov.Core()
luid = core.get_property("GPU.", "DEVICE_LUID")
print luid
This luid can be passed to ovep provider option like ,
ProviderOpitons ov_options;
ov_options[device_type]=AUTO:GPU,CPU;
ov_options[device_luid] = beff000000000000

Checks to be done :
device_type must be set and it should have GPU in it.
For eg :
GPU
AUTO:GPU
AUTO:GPU.0, GPU.1, CPU

device_luid can consist of multiple LUIDs. But they must be comma seperated. Each of the LUID must correspond to a GPU HW. Even if single LUID is incorrect the error must be thrown

Expected output in case of multiple GPU's specified and single LUID is passed is
For device_type=AUTO:GPU.2, GPU.1, GPU.0, CPU and device_luid = beff000000000000 (that corresponds to GPU.1) , then device_type should be
AUTO:GPU.1, CPU

@preetha-intel preetha-intel force-pushed the preetha/device_name_refactor branch from 266b797 to 434add6 Compare March 28, 2025 14:10
@sfatimar
Copy link

sfatimar commented Apr 1, 2025

This PR does not have Device LUID changes. Are they in a separate branch. We need to branch off for UD18 , can we make sure that this PR merges in by today/tomorrow ?

Copy link

@MayureshV1 MayureshV1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@preetha-intel preetha-intel force-pushed the preetha/device_name_refactor branch from a456f2d to 2c5a671 Compare April 4, 2025 19:42
@MayureshV1 MayureshV1 merged commit 80dfee9 into ovep-develop Apr 4, 2025
6 of 8 checks passed
@preetha-intel preetha-intel deleted the preetha/device_name_refactor branch April 5, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants